From nobody Tue Nov 19 19:51:56 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XtFWK2Br8z5fN68 for ; Tue, 19 Nov 2024 19:51:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XtFWJ5ZKcz4d1d for ; Tue, 19 Nov 2024 19:51:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732045916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N+x6TA6unB/f3fbOF5LKSAcTvT3NMhaxhetOzYE2Skc=; b=ugCOZdq9LwCWzJt2i7xRed0AD6NuLhRbgU4DBama7p6wuoJQ7FW5uxnb0j9op90pHLPQrK fCGZiTYrxmRBVvUt05ET39xiZOsNGz0fRw7EltPWuuODpeCI9vMOPyuX7TiIwAbczV9YOk S0ebhodrtE/EseX2wxpWVWfHtTnXseMnsr11aIL2QGED+myWXY+eB/pWSaBdm+iZegqd2S 7LfycQrubZ5pE4PYuRaTJeLPtXeTw5TR8cc9YvpoZtHNwfRLzTEZXJ3DLeiWs8FJ5CixHM zOOw+dwN2vjacxyJ1D/Ef59DPp++xJKRMjopmiWH/e030Cy7l+4U86SzZBBKjQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732045916; a=rsa-sha256; cv=none; b=gOj46OeKTsxmFrp0L6jjD3qslHSaOYG3uFbfoaDoCE4myQf9bnPD1m0yIY5rNVh5vzx4Df LslWxximvW1BwLfYKUqmvjRNcIV/q19YLCGD1ITG1skrOOMkjfE3/MWTb9zi3pMa208gUO ZETu8O/M1AgykgDjeIcCk92QkXFffO06Dro3fenPAVg70h7eATd6O+GemO2C5KsKZG0aUn eYOc9TqHS/EjyCOzhxeq7Yf2yJ6OeEGoy2l0zFOlcZTIPlIfGV9cb7DQ/M184hzdrjj8lS AkSB8galaPkXGtOoOKzUsC/6LubLA+GUu3+Nflc0j7eoDl0LwGqiEPTXUmPMbQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XtFWJ59mSzNls for ; Tue, 19 Nov 2024 19:51:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4AJJpumI032441 for ; Tue, 19 Nov 2024 19:51:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4AJJpuHV032438 for bugs@FreeBSD.org; Tue, 19 Nov 2024 19:51:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 277959] Refactor of usr.sbin/daemon caused regression in restart parameter Date: Tue, 19 Nov 2024 19:51:56 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.3-STABLE X-Bugzilla-Keywords: regression, vendor X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277959 --- Comment #16 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D9ab59e900c1dd693b4d14285389a035e8= 1341789 commit 9ab59e900c1dd693b4d14285389a035e81341789 Author: Kyle Evans AuthorDate: 2024-11-19 19:51:27 +0000 Commit: Kyle Evans CommitDate: 2024-11-19 19:51:27 +0000 daemon: tests: add a test for missed SIGTERM This is somewhaht hard to test reliably, but we'll give it a shot. Sta= rtup a sleep(1) daemon with a hefty restart delay. In refactoring of daemon= (8), we inadvertently started dropping SIGTERMs that came in while we were waiting to restart the child, so we employ the strategy: - Pop the child sleep(1) first - Wait for sleep(1) to exit (pid file truncated) - Pop the daemon(8) with a SIGTERM - Wait for daemon(8) to exit The pidfile is specifically truncated outside of the event loop so that= we don't have a kqueue to catch it in the current model. PR: 277959 Reviewed by: des, markj Differential Revision: https://reviews.freebsd.org/D47005 usr.sbin/daemon/tests/daemon_test.sh | 38 ++++++++++++++++++++++++++++++++= ++++ 1 file changed, 38 insertions(+) --=20 You are receiving this mail because: You are on the CC list for the bug.=