From nobody Tue Nov 19 19:51:52 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XtFWG6g95z5fN67 for ; Tue, 19 Nov 2024 19:51:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XtFWG40llz4d16 for ; Tue, 19 Nov 2024 19:51:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732045914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D6dtNGEaIJkrYrqa28KoarfDlu2pP8RvXO5b+8ciaVM=; b=BWCwFl0BXtJL0P2PInuA6h3JeTN7O/GF5MGkPqW4HuKkspqV4KOHkyv1oTNpjQ30zTZseS 26TUYzN5tyM4ltI7x5/ag3pLXGI8EXmbANUDEUsrdx4AaYZZpBeVxtloViEzJq1McRIr6U o21V3r+4OIAHTdjBNZCpmXinEHbrVPNAq6eawpXg4mrExin5VCK2KF9TJIgwoCy1A4hoks WC1Vi78YUUKbj+pVzUEiWZk/DWTfyGcoeYshmbQHTQu3Reub4W6+2MLCq98uQuIG3/TDaZ i5byzykffADBFsgZtUTMzJiE753aA3tz8OcV1q5Uu/MS1Szehon5ie6z3WtOLQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732045914; a=rsa-sha256; cv=none; b=xu/nC7Hc8NTsx+bvrz1XkGPYfSD+CIUq1ZIy7wfuyPNZl6unB3+v7db5hNzzOpqQlmMfGM ekF5n7xQUGtzpjZ9Vik4DJ0uS/lCMmrapKpy/omYgMIDSd1Q4F0fTsb7lQbCqpXFtQYQEq 4HiDdi9jhn2BAUBuPwGiajc5pcvXH5izs5xKcPYsJTZGOVbPZj21Pw85GudIlMdHbekdEy VeMsu8w2sLqEegktkxQ2mi8uLllgaPGwHUAv9sfEyBz5WpFm3ng+12/NVO6MfvgK5ZKC6G yDzr8aH4ca/dsobmCDlC9b7TbtS5xwBYmzRRMIdzNECriL+7sOnEBiStdp/U9g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XtFWG3X95zP19 for ; Tue, 19 Nov 2024 19:51:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4AJJpsKt032375 for ; Tue, 19 Nov 2024 19:51:54 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4AJJpsgc032373 for bugs@FreeBSD.org; Tue, 19 Nov 2024 19:51:54 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 277959] Refactor of usr.sbin/daemon caused regression in restart parameter Date: Tue, 19 Nov 2024 19:51:52 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.3-STABLE X-Bugzilla-Keywords: regression, vendor X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277959 --- Comment #15 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dbc1dfc316a2bba97773a14b96f5e976a5= 2524be4 commit bc1dfc316a2bba97773a14b96f5e976a52524be4 Author: Kyle Evans AuthorDate: 2024-11-19 19:51:27 +0000 Commit: Kyle Evans CommitDate: 2024-11-19 19:51:27 +0000 daemon: stop rebuilding the kqueue every restart of the child We populate the kqueue with all of four kevents: three signal handlers = and one for read of the child pipe. Every time we start the child, we rebu= ild this kqueue from scratch for the child and tear it down before we exit = and check if we need to restart the child. As a consequence, we effectively drop any of the signals we're interested in between restarts. Push the kqueue out into the daemon state to avoid losing any signal ev= ents in the process, and reimplement the restart timer in terms of kqueue timers. The pipe read event will be automatically deleted upon last close, which leaves us with only the signal events that really get retained between restarts of the child. PR: 277959 Reviewed by: des, markj Differential Revision: https://reviews.freebsd.org/D47004 usr.sbin/daemon/daemon.c | 121 +++++++++++++++++++++++++++++++++++++++----= ---- 1 file changed, 101 insertions(+), 20 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=