[Bug 282832] makefs zfs creates images with the same guid

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282832

--- Comment #1 from Pat Maddox <pat@patmaddox.com> ---
I see there is a comment [1] about using a fixed seed:

        /*
         * Use a fixed seed to provide reproducible pseudo-random numbers for
         * on-disk structures when needed (e.g., GUIDs, ZAP hash salts).
         */

When are these needed to be reproducible?

Should makefs take another flag to produce random GUIDs, or have a note in the
man page that it will always produce the same GUID? I spent quite a bit of time
trying to load two images into bhyve before realizing it was a guid conflict.

I don't think it should be necessary to import the zpool and reguid it, so I'd
be in favor of a flag if there's some reason the default should always produce
the same GUID.

[1] https://cgit.freebsd.org/src/tree/usr.sbin/makefs/zfs.c#n787

-- 
You are receiving this mail because:
You are the assignee for the bug.