From nobody Tue May 21 16:15:12 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VkKKD3wM4z5Lj0V for ; Tue, 21 May 2024 16:15:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VkKKD1tYWz4dxq for ; Tue, 21 May 2024 16:15:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716308112; a=rsa-sha256; cv=none; b=ji41rzZax9SIMjvB3idjzMHAI9rJ2tyPq8ifFz9g8bEyerbNYIe+l+iZ8n8eY9THLGpOOi 4byz23s7RD4G1Mb3zu+vy2f+jeYu/oX8Iy1ueu89g8f83hwikj/aFqPEVTwTyIumZB/CZM HpNIv3eNghwXVVDm9UcZ5ZLGlTS5LPVz/nFI2HgoXYQBbAPG98OcrPa54LRTBMQwKx7Z1u tZ3MX457LyO22D+dCGpGw0i9dqEd1EOBzRFPi2K9g23u7OcSd8GNvE+y6+On9SVbKpJ0fN /TMyr/440mZTcZWV6phnyJOT9vnFQb0PhxcuLus/0u2PdMv24l8FOXeM81Tgsw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716308112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+CysVdpDlTAUa+mgKSpmQCbB2mxmCs1twX5NuKTBDlw=; b=fWJmgcq/mg/DoipfOvdj74janVvazDQYDAUwiV/ePSz32KFFuJMEPZlPAUzL+6ntrAlAw1 wjvEc9cK68dsm4BIujZiLX6BT4ZmOQwjg+anOF7mIy5QRe5Hyiu+snI/WTRPBcmYmOy1Ax //tkkijwNNtAj6Bs6m5veVLAK/z/dNwnM9kTYTOFcdmD4s4v/3yL11jWH31bEGisUnwSvI FQyQvhPA5ecgzeTAmf9mmiQOV13St55AgsLXnzAfVy+UxrblN/zths2yEKUzuFPpKSgSwP nIvSnv7W3eNrcQDtPQJriY3XscgPyLzk+1ZWnj8J7ock8xszC8IeEOX6te9DFA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VkKKD1VBVzT5V for ; Tue, 21 May 2024 16:15:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 44LGFCFb066130 for ; Tue, 21 May 2024 16:15:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 44LGFCei066125 for bugs@FreeBSD.org; Tue, 21 May 2024 16:15:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 279199] cross-compile installworld fails attempting to copy vdso library Date: Tue, 21 May 2024 16:15:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: brooks@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D279199 Brooks Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brooks@FreeBSD.org --- Comment #1 from Brooks Davis --- What source version are you building? This should have been fixed long ago (the fixes were in the stable/14 when it was branched and MFC'd to stable/1= 3).=20 If you need to merge them to a local branch, here are the changes: commit b3b462229f972e2ed24d450d7d2f8855cdd58a87 Author: Ed Maste Date: Fri Apr 1 09:58:47 2022 -0400 installworld: handle ldd including preloaded objects The installworld target makes a temporary copy of binaries to be used during the install. Libraries that they depend on are also included, found by using `ldd`. After commit 0913953c9ed0 ldd started listing preloaded objects, including [vdso], under a [preloaded] header. Skip ldd output that is enclosed in square brackets. Reviewed by: cy, kib [earlier version] MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D34734 and then I rewrote it to be zsh friendly with: commit bda5d2a45c8dcc9bbeb71cddeef930ffa6a47f23 Author: Brooks Davis Date: Fri Jul 1 08:33:16 2022 +0100 installworld: improve portability of ldd use b3b462229f97 added a case statement to ignore lines containing strings in square brackets such as "[vdso]" and "[preloaded]". On MacOS Monterey where /bin/sh may be zsh, this fails with: /bin/sh: -c: line 0: syntax error near unexpected token `;;' Invoke grep in the pipeline to remove such lines instead. Reviewed by: emaste Sponsored by: DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D35618 diff --git a/Makefile.inc1 b/Makefile.inc1 index 20c537512273..12bb892dfd58 100644 --- a/Makefile.inc1 +++ b/Makefile.inc1 @@ -1368,12 +1368,8 @@ distributeworld installworld stageworld: _installcheck_world .PHONY fi; \ done); \ if [ -z "${CROSSBUILD_HOST}" ] ; then \ - libs=3D$$(ldd -f "%o %p\n" -f "%o %p\n" $$progs 2>/dev/null= | sort -u | \ + libs=3D$$(ldd -f "%o %p\n" -f "%o %p\n" $$progs 2>/dev/null= | sort -u | grep -Ev '\[.*]' | \ while read line; do \ - case $$line in \ - "["*"]") \ - continue;; \ - esac; \ set -- $$line; \ if [ "$$2 $$3" !=3D "not found" ]; then \ echo $$2; \ --=20 You are receiving this mail because: You are the assignee for the bug.=