From nobody Thu May 16 01:02:08 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VfsJ04CCZz5KBBj for ; Thu, 16 May 2024 01:02:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VfsJ0399nz4TjZ for ; Thu, 16 May 2024 01:02:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715821328; a=rsa-sha256; cv=none; b=sK4p+QVdDI3339r9gWTg659fv33m4EcJbI5b69BsINMRcuzQ0ZKjH9snK26ogtaVI72NpL iutPhn/JYsCdIysuPprFbOxvzAIs6vz75zR9wuOlOKpa2QCnFCEc1oVvee7or9oUBa/w1H JJ/oTlfoS+sASnGW4DrkMx7W7J/QxU38i8zHQP6DmWLJN5f7AzkR5ytYm0Mr6VZewp2Mf8 ta5NjXCwRyXrL3fMoECxDQD9SGMGel6XY/I1PPPS7K1WhUH2q88ygofdPxl0KCaoliYCA7 bAyU/4+TIILFByVgNgoLwiT7yJiWcGnHpWcneO8kuJiIZQb8/gVzHwWvua4c3A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715821328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LrdlZasNlc86+3ncvcNXj1AA6WsxBPbhy/MhJlyWV6o=; b=XnXVyL/zREZJrSzFOweDa+2NWaAp4ek/JCswmylXdqIMOigI7VR1vNb2f+zs9bdeKQpAq/ JfwK6JBu0HZGaQcfKxsRKW+6jsxJXExVJVjC16zR27NLY7N2BIorh6cEQ5zXUPIwW1Zok9 Q2TFAjzLFsKOtNBhLdpsCoddVAPo+5FJ/3t2Iw8ihBS0ww3M8LSxMxfu7jh3RUpezgha74 bNZGpcWwDcMfpp9EnCKRYvh6Zrl+54Rce1Z6YgoTpWdnWLUfE2CXnnuYlI74T9QZVfKCuB jZoaZDHRDKY9NmWGGCpitJOC6jPmz11Fp/Tnd1+mkXCA1vRFSVljWCbB4Ve1Cw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VfsJ02nZ3zdBg for ; Thu, 16 May 2024 01:02:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 44G128Q6063629 for ; Thu, 16 May 2024 01:02:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 44G128Dp063626 for bugs@FreeBSD.org; Thu, 16 May 2024 01:02:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 265311] silly mount() arguments with MNT_UPDATE and MNT_UNION can cause kernel page-fault Date: Thu, 16 May 2024 01:02:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265311 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D21ccdb4119afdfdfeaa80e9c8514171c6= 5b35862 commit 21ccdb4119afdfdfeaa80e9c8514171c65b35862 Author: Konstantin Belousov AuthorDate: 2024-05-15 09:54:49 +0000 Commit: Konstantin Belousov CommitDate: 2024-05-16 01:00:26 +0000 vfs_domount_update(): postpone setting MNT_UNION until VFS_MOUNT() is d= one The file system that handles updating the mount point might do lookups during the update, in which case it could find the flag MNT_UNION set on the mp while mount point is still not updated. In particular, the rootvp->v_mount->mnt_vnodecovered is not yet set. Delay setting MNT_UNION until the mount is performed. PR: 265311 Reported by: Robert Morris Reviewed by: mckusick, olce Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D45208 sys/kern/vfs_mount.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=