[Bug 277462] lib/libpam: build error: "LDADD_pam is recursive" in NO_SHARED= build

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 03 Mar 2024 22:59:50 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277462

            Bug ID: 277462
           Summary: lib/libpam: build error: "LDADD_pam is recursive" in
                    NO_SHARED= build
           Product: Base System
           Version: 14.0-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: bugs@FreeBSD.org
          Reporter: me@svmhdvn.name

When building FreeBSD stable/14 HEAD using NO_SHARED=, I run into make errors
like the following on all subdirs that depend on PAM through "LIBADD+= pam":

Variable LDADD_pam is recursive.                                                
        in
/usr/local/poudriere/jails/poudriere_stable14_MYN100M/usr/src/share/mk/bsd.libnames.mk:178 
        in
/usr/local/poudriere/jails/poudriere_stable14_MYN100M/usr/src/share/mk/bsd.prog.mk:269 
        in
/usr/local/poudriere/jails/poudriere_stable14_MYN100M/usr/src/secure/usr.sbin/sshd/Makefile:70 

make[5]: stopped in
/usr/local/poudriere/jails/poudriere_stable14_MYN100M/usr/src/secure/usr.sbin/sshd

I see that the reason is due to libpam depending on libpam_modules, which in
turn depends on libpam.

@bdrewery This commit[0] removes the old logic of hacking around this case. How
can I do a successful base system build with NO_SHARED= ?

[0]
https://cgit.freebsd.org/src/commit/lib/libpam/modules/Makefile.inc?id=7cbd0a2953a27e74f8b1b261808068719c1f5260

-- 
You are receiving this mail because:
You are the assignee for the bug.