From nobody Tue Jul 02 20:15:39 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WDDgH2ZtCz5PFyc for ; Tue, 02 Jul 2024 20:15:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WDDgH0Vw4z4ljb for ; Tue, 2 Jul 2024 20:15:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1719951339; a=rsa-sha256; cv=none; b=dLLUrvquPDC5oN+lFl2d7FE5qlLom2gi6aYKT1UAs0jaXIzYTkyTfD9RMRUKw/2BJcsMVa yuziQh27bfAS/9Lb74poqLm/LsbemRheRDcx+n63d3hccMKwSyXLVoWS0BTgf0nG9yYBoP 16kl4hnXrBqhfbRI4MUGLchyt3WxILXrGh9cg2Izh+m7W/DAksBZPDsTIN7taKGciI8OeM sCGAF/xqfLkQOkt5pudS+KDVRR54Zh8HZFN5YHxIv0uA3TYh1u95hVxcR6RNHzVAtlfhel Mw6yhBNkLsTt3pVdjFdX3L1k2CKcjAK2RQ15i41brfJk4mSBlgfyTWO16mtAjA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719951339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Py4f3CCpBtl6zmadQfmX+VepMWp7sYINSktM+SP/7YM=; b=vv84FtXLeaEVBmWd/0izefXfW9DNHxzkbd6PZpjAeBHXMCEXf7koE/5exFElkgvwjfu31U /x/yww8+x98MtLAJKA/osuOSbYCoL74m+IiS9bhm4Z/6wX5+FRpIOWiPMooIPwTM15tJ0x hrrmVb0BkHpvLdEwuc6VUvWapcY3EKgc9bvaf+qQM9EwwXDWRGt0eQLLhhw9jjdpqeKrEm mI1ucuDZeNaMUmbUhC2/PxMUsCd9N0Dz+8I8Y5W8ybgXYacdIMvk04UJtvVboJouMRY8Y6 /TETVsPkzrn+9sAv5Jn6+oHyoB8MO6Ys7kpxpx3EMj1mJpvjzXCD6F5ANW3g4g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WDDgH06RHz11sv for ; Tue, 2 Jul 2024 20:15:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 462KFctE017317 for ; Tue, 2 Jul 2024 20:15:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 462KFcSJ017316 for bugs@FreeBSD.org; Tue, 2 Jul 2024 20:15:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 280098] 9pfs panics on qemu+kvm Date: Tue, 02 Jul 2024 20:15:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: danilo@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280098 Bug ID: 280098 Summary: 9pfs panics on qemu+kvm Product: Base System Version: 15.0-CURRENT Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: danilo@FreeBSD.org I'm running FreeBSD-CURRENT on a qemu/kvm instance (managed by LXD). FreeBSD freebsd 15.0-CURRENT FreeBSD 15.0-CURRENT #20 main-n271013-de1e9133= 9b1: Tue Jul 2 20:18:44 IST 2024=20=20=20=20 root@freebsd:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64 When I load the virtio_9pfs module the system immediately panics: Unread portion of the kernel message buffer: virtio_p9fs0: on virtio_pci7 panic: vtpci_modern_read_dev_config: device virtio_pci7 invalid device read length 6 offset 2 cpuid =3D 1 time =3D 1719948130 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe006b124= 710 vpanic() at vpanic+0x13f/frame 0xfffffe006b124840 panic() at panic+0x43/frame 0xfffffe006b1248a0 vtpci_modern_read_dev_config() at vtpci_modern_read_dev_config+0x1e6/frame 0xfffffe006b1248f0 vt9p_attach() at vt9p_attach+0xe2/frame 0xfffffe006b124970 device_attach() at device_attach+0x3aa/frame 0xfffffe006b1249b0 vtpci_modern_probe_and_attach_child() at vtpci_modern_probe_and_attach_child+0x7b/frame 0xfffffe006b1249e0 devclass_driver_added() at devclass_driver_added+0x29/frame 0xfffffe006b124= a10 devclass_add_driver() at devclass_add_driver+0x138/frame 0xfffffe006b124a50 module_register_init() at module_register_init+0xb0/frame 0xfffffe006b124a80 linker_load_module() at linker_load_module+0xc23/frame 0xfffffe006b124d80 kern_kldload() at kern_kldload+0x16e/frame 0xfffffe006b124dd0 sys_kldload() at sys_kldload+0x5c/frame 0xfffffe006b124e00 amd64_syscall() at amd64_syscall+0x158/frame 0xfffffe006b124f30 fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe006b124f30 --- syscall (304, FreeBSD ELF64, kldload), rip =3D 0x1292ad7867da, rsp =3D 0x1292aa5aeaa8, rbp =3D 0x1292aa5af020 --- As you can see the panic happens inside vtpci_modern_read_dev_config becaus= e it tried to read 6 bytes. This function only accepts reading power-of-two sizes. As far as I can tell, the intention was to use virtio_read_device_config() = to read the 9pfs tag, which is "config" in my case, so 6 bytes. In fact, when I change the last argument (len) to 4, the device attaches an= d I get: virtio_p9fs0: on virtio_pci7 virtio_p9fs0: Mount tag: conf Note the mount tag "conf" missing the "ig". This is the 9p related configuration LXD will create for qemu: [device "dev-qemu_config-drive-9p"]=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 driver =3D "virtio-9p-pci"=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 bus =3D "qemu_pcie2"=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 addr =3D "00.0"=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 multifunction =3D "on"=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 mount_tag =3D "config"=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 fsdev =3D "qemu_config"=20=20 Here is a backtrace from kgdb: (kgdb) bt #0 __curthread () at /usr/src/sys/amd64/include/pcpu_aux.h:57 #1 doadump (textdump=3Dtextdump@entry=3D0) at /usr/src/sys/kern/kern_shutdown.c:404 #2 0xffffffff8049d09a in db_dump (dummy=3D, dummy2=3D, dummy3=3D, dummy4=3D) at /usr/src/sys/ddb/db_command.c:595 #3 0xffffffff8049ce9d in db_command (last_cmdp=3D, cmd_table=3D, dopager=3Dtrue) at /usr/src/sys/ddb/db_command= .c:508 #4 0xffffffff8049cb5d in db_command_loop () at /usr/src/sys/ddb/db_command.c:555 #5 0xffffffff804a0616 in db_trap (type=3D, code=3D) at /usr/src/sys/ddb/db_main.c:267 #6 0xffffffff80b9435f in kdb_trap (type=3Dtype@entry=3D3, code=3Dcode@entr= y=3D0, tf=3Dtf@entry=3D0xfffffe006b124650) at /usr/src/sys/kern/subr_kdb.c:790 #7 0xffffffff8105f409 in trap (frame=3D0xfffffe006b124650) at /usr/src/sys/amd64/amd64/trap.c:606 #8 #9 kdb_enter (why=3D, msg=3D) at /usr/src/sys/kern/subr_kdb.c:556 #10 0xffffffff80b44c10 in vpanic (fmt=3D0xffffffff812544ba "%s: device %s i= nvalid device read length %d offset %d", ap=3Dap@entry=3D0xfffffe006b124880) at /usr/src/sys/kern/kern_shutdown.c:967 #11 0xffffffff80b44a93 in panic (fmt=3D0xffffffff81b97480 "\331\f\024\201\377\377\377\377") at /usr/src/sys/kern/kern_shutdown.c:892 #12 0xffffffff8096b1b6 in vtpci_modern_read_dev_config (dev=3D0xfffff80001a= 67000, offset=3D2, dst=3D0xfffff800011b5f40, length=3D6) at /usr/src/sys/dev/virtio/pci/virtio_pci_modern.c:675 #13 0xffffffff82c08562 in vt9p_attach (dev=3D0xfffff80001a68e00) at /usr/src/sys/dev/virtio/p9fs/virtio_p9fs.c:355 #14 0xffffffff80b823fa in DEVICE_ATTACH (dev=3D0xfffff80001a68e00) at ./device_if.h:195 #15 device_attach (dev=3Ddev@entry=3D0xfffff80001a68e00) at /usr/src/sys/kern/subr_bus.c:2548 #16 0xffffffff8096b90b in vtpci_modern_probe_and_attach_child (sc=3D0xfffff80001a60800) at /usr/src/sys/dev/virtio/pci/virtio_pci_modern.= c:1141 #17 0xffffffff80b7f9a9 in BUS_DRIVER_ADDED (_dev=3D0xfffff80001a67000, _driver=3D0xffffffff82c0a2a8 ) at ./bus_if.h:210 #18 devclass_driver_added (dc=3Ddc@entry=3D0xfffff8000187d480, driver=3Ddriver@entry=3D0xffffffff82c0a2a8 ) at /usr/src/sys/kern/subr_bus.c:603 #19 0xffffffff80b7f8f8 in devclass_add_driver (dc=3D0xfffff8000187d480, driver=3D0xffffffff82c0a2a8 , pass=3D2147483647, dcp=3D0x0) at /usr/src/sys/kern/subr_bus.c:690 #20 0xffffffff80b1de30 in module_register_init (arg=3D0xffffffff82c0a260 ) at /usr/src/sys/kern/kern_module.c:120 #21 0xffffffff80b0d003 in linker_file_sysinit (lf=3D0xfffff8000e9aac00) at /usr/src/sys/kern/kern_linker.c:241 #22 linker_load_file (filename=3D0xfffff80003a8d1e0 "/boot/kernel/virtio_p9fs.ko", result=3D) at /usr/src/sys/kern/kern_linker.c:500 #23 linker_load_module (kldname=3Dkldname@entry=3D0x0, modname=3Dmodname@entry=3D0xfffff80001793800 "virtio_p9fs", parent=3Dparent@entry=3D0x0, verinfo=3Dverinfo@entry=3D0x0, lfpp=3Dlfpp@entry=3D0xfffffe006b124da0) at /usr/src/sys/kern/kern_linker.c:= 2288 #24 0xffffffff80b0ed3e in kern_kldload (td=3Dtd@entry=3D0xfffff8000ef48000, file=3Dfile@entry=3D0xfffff80001793800 "virtio_p9fs", fileid=3Dfileid@entry=3D0xfffffe006b124de4) at /usr/src/sys/kern/kern_linke= r.c:1236 #25 0xffffffff80b0ee3c in sys_kldload (td=3D0xfffff8000ef48000, uap=3D) at /usr/src/sys/kern/kern_linker.c:1259 #26 0xffffffff81060818 in syscallenter (td=3D0xfffff8000ef48000) at /usr/src/sys/amd64/amd64/../../kern/subr_syscall.c:189 #27 amd64_syscall (td=3D0xfffff8000ef48000, traced=3D0) at /usr/src/sys/amd64/amd64/trap.c:1192 Let me know if more information is needed. --=20 You are receiving this mail because: You are the assignee for the bug.=