From nobody Tue Jul 02 19:21:47 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WDCT75Qlvz5P7CH for ; Tue, 02 Jul 2024 19:21:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WDCT74MmTz4dK2 for ; Tue, 2 Jul 2024 19:21:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1719948107; a=rsa-sha256; cv=none; b=jIMzOZaLYiEyyjc3qwVd9q1kriaSdcqFJCEWQvvWvvPqHepFl+yunTLzK0xrI9n4oYBR2i JCrerjQjTX3XcZxWLvq4DEefhoKJlvvvGKBGpA/c0NsKphMU5u+BagqLMUPBmMSLrIlDse xZ6+JTpbi3QdGgfRCJkNAnfGEuqmHmXXVV0cgm4X/DyUHF7iR/gytAE2alMaOgp5XiR/Uj OzPFYuvPvQ1cytRq40+NicXKh/FkCTDZLW7VNr+ztpUwMTteQrPZcG5dIzcj3Uvyk5B57t /1AVcQviQJs9tfG1JmAlW6VDNTyaDVQZYKehox/SofgfXC+84PmsDD0mMp0HZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719948107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x8naqJwxldiFgzH0RxxcKO9Pzr6JTTu3Y8+pG9nPc1U=; b=opnvhtaQul4jrxqlTpjl/toE3kw2/B969aGkSz/V3x/KcEemrHMkTtgeQuEic3RtGdyx6a a952ZRw8r+34+LLjGbyqfP0fQYGneUqD/U5phpIXAISvCDqH1nq8jl0VDllp0tPjrqUo68 Af9h8qArDtBl7mOphiEznrO1ha9Qrh8YqhOi2vWcdI5LJegjliU3czIsOaU0ke9HFCyNCL IcWZDjFaygkItfz1q6ginH8EdkWPifoykqbuF6H/aq1QDdFNkYeqdXFFxqbRWJfdvcodUt nzAOEnLBXDcmWxsV6TPVAnb8UwXu5lOFqFh2qN6JRuF98+qkD4B6hiwsU/4N6w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WDCT73zP1z11Fv for ; Tue, 2 Jul 2024 19:21:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 462JLlFB075153 for ; Tue, 2 Jul 2024 19:21:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 462JLle0075152 for bugs@FreeBSD.org; Tue, 2 Jul 2024 19:21:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 280097] Warning printed when FIBs are expanded is unhelpful and confusing Date: Tue, 02 Jul 2024 19:21:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jeremy.fbbg@baymoo.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280097 Bug ID: 280097 Summary: Warning printed when FIBs are expanded is unhelpful and confusing Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: jeremy.fbbg@baymoo.org Summary =3D=3D=3D=3D=3D=3D=3D The warning printed when the kernel is instructed to grow the routing tables with the addition of a new FIB is unhelpful and confusing. Currently the warning reads: WARNING: Adding ifaddrs to all fibs has been turned off by default. Consider tuning net.add_addr_allfibs if needed (sys/net/route/route_tables.c:233) Details =3D=3D=3D=3D=3D=3D=3D The issue with this message is that the action that triggers it is the act = of growing the number of FIBs in the system -- which typically happens at boot time -- and not the act of adding address to any interfaces. The message ma= kes it seem that the user has performed one of these actions when in fact they = have not, and makes it difficult for the user to understand what needs to be don= e to REMOVE the message. I know this because I spent an hour trying to figure out what was wrong wit= h my system configuration because of this message and in the end, I found out th= at NOTHING was wrong. Proposal =3D=3D=3D=3D=3D=3D=3D=3D I propose that the warning be changed ever so slightly so that the user can tell 1. When it was generated (when net.fibs is adjusted) 2. That the warning is a reminder, not the detection of a problem. Perhaps: --- route_tables.c.orig 2024-07-02 12:18:49.627899000 -0700 +++ route_tables.c 2024-07-02 12:20:44.759937000 -0700 @@ -231,8 +231,11 @@ M_RTABLE, M_WAITOK | M_ZERO); if ((num_tables > 1) && (V_rt_add_addr_allfibs =3D=3D 0)) - printf("WARNING: Adding ifaddrs to all fibs has been turned= off " + printf("%s adjusted to %d. REMINDER: " + "Adding ifaddrs to all fibs has been turned off " "by default. Consider tuning %s if needed\n", + "net.fibs", + num_tables, "net.add_addr_allfibs"); #ifdef FIB_ALGO --=20 You are receiving this mail because: You are the assignee for the bug.=