From nobody Sun Feb 11 02:48:46 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TXX8t3qwVz59C6V for ; Sun, 11 Feb 2024 02:48:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TXX8s6Srmz4H0S for ; Sun, 11 Feb 2024 02:48:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707619725; a=rsa-sha256; cv=none; b=jWSScbalvcAQ8AlLrl7ypMaUGPtHE/103yzEC6oJ+zxnwaEi95r+meabV8mhnPOQYyx4e3 3nFEprHWrnK8kdu9qagpM7ThSNT9pqvOxoQT2n032kOnDNNkE6Ic7czeMHxLQu3jiPYoAu JB+LoUiTtIxOmZJwTL92Hb4u7xbYCIznTdxsgDMJ1dNeKyD3t0+AMkzTh5nrwuO5A4kJZ9 eSaYhqPhkXF7zODlDmOK8dPde/BZ6uG27mFQj5g865nb566Op2KL1yhimaanmJRbeaEREv jbr+l3q+D5fn7WVFd8K0Egts8Zl/rUeVMSgFSFIAG/cWQ9jmh8e6Fm2AzIv2AQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707619725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UBEhCe9ulVg1bndsHFyWIGsliPXTdCOUTZ3kup/EI0s=; b=ib2JiLVTXoiVNUf+TDf/QZLcljGoSbUybHQ7/XwV9ztA9EqPVNrrIbyDlx2+8eTYDaJfOz 73VwtmMb848S7QpZ9418rqyOYTUfJcPPMJyFjRFrvPm9+0Sw7+ueWeohgDHXR0pQ7FuNdS skeBPukEGAQbduEy2iBSQ7ezIX6qCHfRDRsNbt4Fv0qhhQDCXnKv5YqMTxfqOfWVqdFFLk 6bUJrBqPPcxxDja4NY056h3P8TAnVA8ycaiebQjNz266kgetJfGsFokrN0flF4ghpjJiqb nJXeHAAquW9SFYC7Z/JQraJyAZbMk7zpCIqrVy5IeVBfdJlkVdcK1G0qabYEwg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TXX8s5YZtzhZV for ; Sun, 11 Feb 2024 02:48:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41B2mjF0056584 for ; Sun, 11 Feb 2024 02:48:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41B2mjZY056583 for bugs@FreeBSD.org; Sun, 11 Feb 2024 02:48:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 276962] mac_priority(4) doesn't affect sched_setscheduler(2) Date: Sun, 11 Feb 2024 02:48:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dev@submerge.ch X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276962 --- Comment #1 from Florian Walpen --- Seems like there's a mismatch with different privileges requested. sys/sys/priv.h defines: #define PRIV_SCHED_DIFFCRED 200 /* Exempt scheduling other users. = */ #define PRIV_SCHED_SETPRIORITY 201 /* Can set lower nice value for pr= oc. */ #define PRIV_SCHED_RTPRIO 202 /* Can set real time scheduling. */ #define PRIV_SCHED_SETPOLICY 203 /* Can set scheduler policy. */ #define PRIV_SCHED_SET 204 /* Can set thread scheduler. */ #define PRIV_SCHED_SETPARAM 205 /* Can set thread scheduler params= . */ #define PRIV_SCHED_CPUSET 206 /* Can manipulate cpusets. */ #define PRIV_SCHED_CPUSET_INTR 207 /* Can adjust IRQ to CPU binding. = */ #define PRIV_SCHED_IDPRIO 208 /* Can set idle time scheduling. */ The call to sched_setscheduler() ends up in sys/kern/p1003_1b.c, checking f= or the PRIV_SCHED_SET privilege: kern_sched_setscheduler(struct thread *td, struct thread *targettd, int policy, struct sched_param *param) { ... /* Don't allow non root user to set a scheduler policy. */ error =3D priv_check(td, PRIV_SCHED_SET); if (error) return (error); ... } While mac_priority only grants privileges for PRIV_SCHED_RTPRIO / PRIV_SCHED_SETPOLICY or PRIV_SCHED_IDPRIO. I think sched_setscheduler() does actually set the policy, not the schedule= r, so maybe PRIV_SCHED_SETPOLICY would be more appropriate here. I can have a closer look tomorrow. --=20 You are receiving this mail because: You are the assignee for the bug.=