From nobody Mon Dec 30 19:50:46 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YMRY26PWxz5hgPs for ; Mon, 30 Dec 2024 19:50:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YMRY25HZFz4CwJ for ; Mon, 30 Dec 2024 19:50:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735588246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vplETxkZWInrpN8NKJfQgKeiO6Tr1IWNSM+s+3yD3XE=; b=ti1jk8rYhbTdGFodABBtGVV/Vt2U3WQgx8iFsCb6ZYhB4Fm2tzu9PAmrq+42+dI4FO6FVU LcOuf+W8PjYNtraPGe5ep3SkwkAIGBiT7u9X0u3E3F751QJ/9HlT2kXi7/ZCthhdh61zXe +VFjWetcFpYWu7g1hEq3rqRHc7PZjI8tZAJeJsbSNdBbG3BmX+n/u12b3A1z6+cB2oTGJ3 3tMW6fj6TmUacfJ9AbRe9J39i1jMp5ppNtsEDUshO+1B8r4D+Jide1OOooakrLfn7YD68d 6JYjNuDV+vmYPowsn+wsR9COWjzN7cUFRsEvE9BEQs/PlDPKGocdEoTgncoJUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735588246; a=rsa-sha256; cv=none; b=oPhcxZ1qjq4my8mj6GUnhtWCbX13DLt8tWZiLtNqydRiEg8Pn3JVyaY79+2SdjKI2z0YDh ISAjjAnWjfSRY6ZL55pNc/XtQcfZqqvy2B31/+hifwxphfgCNKcomu0d3bXdYI3cZjpt8p yp3rp9ym1fUdkWl+ySm63FFEAkm7i4A79nAO0KKZRfGlSZnq9uPn6sXO2My1Ybp7vsJmgL StLA6F0aU1NtUWwuyq1DPCNTuAJx3IngOX/ArImc90iKIAiD/SFZowNPjNPpnQOqJYyWel BNbajPjK0DIPjD5a/ODe6UiRCoUdM8KcK7hBFll67UMcsAwnQmCePdqj6uLwkg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YMRY24k7fz174K for ; Mon, 30 Dec 2024 19:50:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4BUJokCN098398 for ; Mon, 30 Dec 2024 19:50:46 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4BUJokbB098397 for bugs@FreeBSD.org; Mon, 30 Dec 2024 19:50:46 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 283112] New Cache files packed into the FreeBSD14.2 release ISO file but not into Beta3 ISO files Date: Mon, 30 Dec 2024 19:50:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 14.2-RELEASE X-Bugzilla-Keywords: vendor X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283112 --- Comment #21 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D1f31d437428014e864bcce1223cf70171= 80e2608 commit 1f31d437428014e864bcce1223cf7017180e2608 Author: Ed Maste AuthorDate: 2024-12-30 15:01:06 +0000 Commit: Ed Maste CommitDate: 2024-12-30 19:48:44 +0000 makefs: Fix cd9660 duplicate directory names Previously we could create cd9660 images with duplicate short (level 2) names. cd9660_level2_convert_filename used a 30-character limit (for files and directories), not including the '.' separator. cd9660_rename_filename used a 31-character limit, including the '.'. Directory names 31 characters or longer (without '.') were shortened to 30 characters, and if a collision occurred cd9660_rename_filename uniquified them starting with the 31st character. Unfortunately the directory record's name_len was already set, so the unique part of the name was stripped off. Directories are up to 31 d-characters (i.e., A-Z 0-9 and _); there is no provision for a '.' in a directory name. Increase the name length limit to 31 for directories, and exclude '.'s. This name mapping and deduplication code is still fragile and convoluted and would beenfit from a more holistic effort. PR: 283238, 283112 Reviewed by: imp Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D48251 usr.sbin/makefs/cd9660.c | 5 ++-- usr.sbin/makefs/tests/makefs_cd9660_tests.sh | 39 ++++++++++++++++++++++++= ++-- usr.sbin/makefs/tests/makefs_tests_common.sh | 2 +- 3 files changed, 41 insertions(+), 5 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=