From nobody Tue Dec 10 23:39:00 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y7FYc4kTZz5g300 for ; Tue, 10 Dec 2024 23:39:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y7FYc1sc6z4p3M for ; Tue, 10 Dec 2024 23:39:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733873940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5iqX8Nm6xKNh2J5WJWdjO4Wi5HjHgKSPl+txEkGrz+4=; b=eQeHmD8S+MMrTYKmlgoYXi/1m9MKbOV+kVWIO6doJWmhB1MBgy4gX4GtSyPg8yaF61vUi1 aLx4CuHsDwae+7i29u6lXHnyOlkgNV/nsp7UBhHHEjA9pGbxttpWH0xXPRt5lT71zBl3ub 3ufbIueU5HOnufq0fEgVEMLJcJpVT07LgQKr69SyE18SMSjKmi7xrR5wOUPUy2wGdrAXUB /zZy8Uql6q0jQGiTr9yHDya0YJ9t5jrpDoRvz/lpF2/aBiNWSxiU5weRIuFdltBzgAPvMr mGbNU0QdQ7nd/jaRPrk7una1Um1Vg7dGwTCGzSnzEd3M1BA+RD9QRgv01K59ng== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733873940; a=rsa-sha256; cv=none; b=YHl71GfFmyCbx4ZypQ/Pr4SB+HiIR+diKMAZBuD4ZIvEGHlT4KYEaaDXySXPragoNKEGy9 6Ok5f8dW+2YuvxArq21OBfdFCZnxOAsV22VaNFTwi0NyEOA5SzwVot6i/zKiNTpz2JLSJN 5pObu0Rbcq7J82UUtLSX80dLAGujSDMGsFrlfriCrsX7sOHq/dym6fWF0/aoGDp2mybUeT pz26Q41P7kGLYa5R/C0lnFwP4803oVeTpDmcA/yEzkHqXefP7PVt4ZaJtEQHX1cRmIdkvA S+RR18kcV88Gr6a2XyZZ/tTiBM2y9nUrMeGm8Ni20KnwiHqUGj61jIAuKhh1VA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y7FYc1TP9zkQt for ; Tue, 10 Dec 2024 23:39:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4BANd0Mg002583 for ; Tue, 10 Dec 2024 23:39:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4BANd0Zi002570 for bugs@FreeBSD.org; Tue, 10 Dec 2024 23:39:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 277959] Refactor of usr.sbin/daemon caused regression in restart parameter Date: Tue, 10 Dec 2024 23:39:00 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.3-STABLE X-Bugzilla-Keywords: regression, vendor X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277959 --- Comment #22 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D4bb1a558a2811a27b1211579cb257a11d= f49c0e1 commit 4bb1a558a2811a27b1211579cb257a11df49c0e1 Author: Kyle Evans AuthorDate: 2024-11-19 19:51:27 +0000 Commit: Kyle Evans CommitDate: 2024-12-10 23:06:11 +0000 daemon: stop rebuilding the kqueue every restart of the child We populate the kqueue with all of four kevents: three signal handlers = and one for read of the child pipe. Every time we start the child, we rebu= ild this kqueue from scratch for the child and tear it down before we exit = and check if we need to restart the child. As a consequence, we effectively drop any of the signals we're interested in between restarts. Push the kqueue out into the daemon state to avoid losing any signal ev= ents in the process, and reimplement the restart timer in terms of kqueue timers. The pipe read event will be automatically deleted upon last close, which leaves us with only the signal events that really get retained between restarts of the child. PR: 277959 Reviewed by: des, markj (cherry picked from commit bc1dfc316a2bba97773a14b96f5e976a52524be4) usr.sbin/daemon/daemon.c | 121 +++++++++++++++++++++++++++++++++++++++----= ---- 1 file changed, 101 insertions(+), 20 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=