From nobody Mon Dec 02 21:11:49 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y2GgT5t9Yz5gRlj for ; Mon, 02 Dec 2024 21:11:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y2GgT4pZhz42wk for ; Mon, 2 Dec 2024 21:11:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733173909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jOBZmaraR47nnlUieMXsGWVzLU+6tOD3/YLfcwqWPbo=; b=EDuOQyxkLH3VfkKkTCLbI+PJg7tdL5EK5nQfNCnVJ7yj5Amld9qcmEM/DvgC82xhD+CCsv UI/YHQGlc3jW9XnQS5rn4OxdyA27wb25lWnZkZbXaHoX0agKpJDdqgVuwF0T+OfgXptI+6 aAtFvqpKuWDLfmC+O8g+fxNQk0hnRq43mDKrzz35q9GIZhAeZxJetqgRFYzsye9s9mA8Y2 EmlEMF/ZHxEO/VwJUC+4XCamXfC7dJ9umExWsO/qgecTD/PpYHji+grTu4T+ZMnH5GJ3Dz CXPP9kNGci6eD15mTYetm8UW3zr/uEwAsmrjZ7/ZoWtwwAw358Acjw7Fwdk41Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733173909; a=rsa-sha256; cv=none; b=XZLCD5o2T58+eVnmWKDHkqX8xF9Fv97tzlbHZ/c0R8wfXAQjMENlpAZ3zKL7FtY3Pahu1Y MIfwjrlnH5PZHAaefOArAye4CCVJdAU7tB6qhQiQkMhgxwer9WPiF9O6CJML/cQAyzpqi8 WAcY4ltOPFmMQyrVYN13jkksPkJ/HLxpdXYVmDAJ+LmKMKh9xRBhZXoKmlH6vXr+OqpQ5N MpsSe0lVmafcYHLxqWoBURfzawZNQX+o0OvfGnlYqsWzGf29zMB+aGfl0NKjDd1So2RpOd ymvZsdl0Z28AfsQwKhFsPj+rj1BsKSarXX8welK/vTccPmIm7mcBzcgFVthXcg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y2GgT4R1YztQ2 for ; Mon, 2 Dec 2024 21:11:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4B2LBnFJ079591 for ; Mon, 2 Dec 2024 21:11:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4B2LBnmi079590 for bugs@FreeBSD.org; Mon, 2 Dec 2024 21:11:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 270404] comsat is willing to try to read and display any file Date: Mon, 02 Dec 2024 21:11:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: security X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270404 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D957f7a2a58e550bd31d8ebec67f99d190= 87746a2 commit 957f7a2a58e550bd31d8ebec67f99d19087746a2 Author: Ed Maste AuthorDate: 2024-11-27 20:36:46 +0000 Commit: Ed Maste CommitDate: 2024-12-02 21:10:31 +0000 comsat: Improve use of setuid() Just return from jkfprintf if either (a) user lookup fails (that is, getpwnam fails) or (b) setuid() to the user's uid fails. If comsat is invoked from inetd using the default of tty:tty we will now return due to setuid() failing rather than fopen() failing. PR: 270404 Reviewed by: kevans Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D47823 (cherry picked from commit 062b69ba045dc0fef3d9b8d73365d2798c05a480) libexec/comsat/comsat.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=