From nobody Mon Aug 26 19:56:42 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt1f33Jjyz5TWTK for ; Mon, 26 Aug 2024 19:56:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt1f24H8zz4Ljn for ; Mon, 26 Aug 2024 19:56:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724702202; a=rsa-sha256; cv=none; b=HFBhYaeTdBNpwIVgUwDh8kM7SIROqSnUsR2Uhm2D0+of49sFFzW6mAeQSv4hKXvzggxanN YDZnVH7kTC+89SCZWsV+psJGTIX1upTJrNM+x8oYfWOFVQVYYH4dr7cbWfj7d7GCulbg55 93qrqUQbLaTW+IB2/hxdl2U1u7+tX89J+yMPSyrI5RPwk3VSCnetj5095Wo8P3N0haA/z9 H2sxLjWHExP14flNg6Hs/9MKxqu+7AUpPOAZI0YFHUZOj0Jmp1L3r9kaA856/wT8cbZweL YrBo514hqMYo7RAByLWROcYDC103G5Hmlml6t6xLqkPFWZH0GMH2aJ/4R29CgA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724702202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RQt9EAO5Hu/FcfCoVB0v+/RCadJJ5c0DJLDG5Dh53bU=; b=UOii7dgFzOWQxyRa4Ltkp8t3Q71qViSLRW6OSTKRL4kSWy83iB7klhsHe+k+d3+g2C90CU 7y4E+W3L+IjPjcawwiuwZ2jLO6VKiw0ZT+fjJ6kUOO3o0HOANfa1fdxBJy4Tuzy7S1Kf4w 9CWUV4IAeGuKL3TKmfrliegM/vUhRKfrcO6TWWN9xADWYBZbk1FzsKPvjJgG32GOGPMUGt Lt2bqrmc7+EuE9yoFp64lHdJ8WIXgX5pCrSeleKgQKq/E2W1pv5c7UGbVspAUCiRJ+Wpyf urL6ZYZwGh6UMe8X3/lTCoAgzAzUBD8luTpdd1YLWBpDFLgaK8y7b7prg1BLhA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt1f23g6hzKpT for ; Mon, 26 Aug 2024 19:56:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47QJugPw005284 for ; Mon, 26 Aug 2024 19:56:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47QJugAr005282 for bugs@FreeBSD.org; Mon, 26 Aug 2024 19:56:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 281082] sys/netgraph/ng_ipfw.c: Using 32bit cookies breaks ipfw ngtee Date: Mon, 26 Aug 2024 19:56:42 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ruben@verweg.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281082 Bug ID: 281082 Summary: sys/netgraph/ng_ipfw.c: Using 32bit cookies breaks ipfw ngtee Product: Base System Version: Unspecified Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: ruben@verweg.com The MFC=E2=80=99ed commit 20e1f207cc789a28783344614d6d1d1c639c5797 (https://cgit.freebsd.org/src/commit/?id=3D20e1f207cc789a28783344614d6d1d1c= 639c5797) MFC=E2=80=99ed to 14.1 as dadf64c5586e5fa5e1018a3d8a02c9873b1121b8 and to 1= 3.3 as 0b9242dea68c44dc630921d3802f3f80f4d84b48 breaks ipfw_netflow. Reversing the patch restores functionality. This might be due to=20 * sys/netinet/ip_fw.h=E2=80=99s ipfw_insn->arg1 still sit at u_int16_t, per= haps truncating one or another so that it remains invisible for ng_ipfw and the = rest of netgraph * sbin/ipfw/ipfw2.c chkarg in case TOK_NGTEE poses a limit of IP_FW_TABLEARG (65535) on the ngtee parameter. Tested on 13.3 with ipfw_netflow and a packetcapture on the receiving port / sudo flowctl netflow: show human Reversing the patch seems less impacting than to figure out where arg1 hand= ling needs to be adjusted for full 32bit operation. --=20 You are receiving this mail because: You are the assignee for the bug.=