From nobody Mon Aug 26 19:14:48 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt0jh3sWpz5TSYF for ; Mon, 26 Aug 2024 19:14:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt0jh1XJ3z4JC0 for ; Mon, 26 Aug 2024 19:14:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724699688; a=rsa-sha256; cv=none; b=AdIWdzyYDOpZNlS9mGsoHVPrD0w1sKET2naZdm7hd34x22mjuTYsxNskLHowpf5UAMarua pzqSgSTNTrltdtgiHnOAF4CEoGBUocYKakRe/w1xjYCZC8wuHnt/pIks/6gkCqDQP8bZ6k nnzxERKj20Ve908cSvQZHIMQg2DV24mQxny4oa11trDb9dE+B7T9TOHWIT3Hr3hP4jBTRQ GhQIbxFOWppAAUbhp5Ifx7hU1TDCgS7ADjA0lDe0hqeSj9v6cjE5hMP6ceoCWkuDkenNVz eMzjCZEpLjlquIYfDj4gTKpMOz2SeVjCV6ejR5YQO22KINca0nq76nC0hQiZaA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724699688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hVgMZf/4LUQrJjIijwGUy65EqIzK/Z8TrsTC1r8hr5g=; b=nzXGiw8RI0ribWMSJ1HBZq+L5rfuUxi4Bqku6vNZyJ28G75bdosmirqY5IvBKv30B2uHDx nJ4lya1FGSQEAdtMO0+rcAFqV++N9bv65DZ7zU0i01EQYZQZACQESLrx7+3nuX+qaqL+IY R2leU2NYkRo0/JrOSZ/7zMM8c5XyzDHL4Z8A5p4ll/qdozHmwZsVFrn9QvlauuP04gaxDZ USy7BI70Y0MP0KOEXmcDL1/Y2Y0vZhfTjSH4U/wz/qHU8BU2cHFmqYpq0EJN6S5xy9Xz45 xvWWHBz+nz9ToYeYVthKtK7Pn124fz+eKfGI3p9agAKhQU0NjOaOiKLtnQGv2g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt0jh10gvzJdY for ; Mon, 26 Aug 2024 19:14:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47QJEm9E038665 for ; Mon, 26 Aug 2024 19:14:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47QJEmpc038664 for bugs@FreeBSD.org; Mon, 26 Aug 2024 19:14:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 280913] [patch] Unexpected state of vnet-jails with ifconfig_DEFAULT="DHCP" in rc.conf(5) Date: Mon, 26 Aug 2024 19:14:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 14.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bugzilla.freebsd@omnilan.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280913 --- Comment #4 from Harald Schmalzbauer --- (In reply to crest from comment #3) Good point. But this patch for syncdhcpif() of /etc/network.subr is not re= ally affected, since $1 in syncdhcpif() was passed unquoted from ifconfig_up() w= hich in turn got it from ifn_start() as unquoted parameter ${ifn}. get_if_var() uses ltr() to normalize IF. From a quick look, only IFNAME consisting of the four ".-/+" punctuation characters are valid, which are unconditionally replaced by the underscore character. rc(8) would break far earlier if somebody manually renamed the interface to anything allowed by t= he core struct (if not prevented by ifconfig(8)) and tries to non-maually atta= ch dhclient to it. For consistency reasons I'd prefer to keep it unquoted since I see no possibility that $1 can ever be anything else than shell variable characters (get_if_var() would fail to return any of the DHCP pseudo-args, so syncdhcp= if() wouldn't be called). The wrong whitespace indention bothers me more ;-) Thanks for looking at it! --=20 You are receiving this mail because: You are the assignee for the bug.=