[Bug 280770] mii_fdt_lookup_phy not checking common subnonode name

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 12 Aug 2024 13:02:07 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280770

            Bug ID: 280770
           Summary: mii_fdt_lookup_phy not checking common subnonode name
           Product: Base System
           Version: 13.3-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: bugs@FreeBSD.org
          Reporter: mibelanger@qnx.com

The following is in mii_fdt_lookup_phy:
        /*
         * Now handle the "switch" case.
         * Search "ports" subnode for nodes that describe a switch port
         * including a PHY xref.
         * Since we have multiple candidates select one based on PHY address.
         */
        ports = ofw_bus_find_child(node, "ports");
        if (ports <= 0)
                return (-1);

The subnode name "ethernet-ports" is more commonly used.  The code should add
an extra attempt with the "ethernet-ports" subnode name.  e.g.

        /*
         * Now handle the "switch" case.
         * Search "ports" subnode for nodes that describe a switch port
         * including a PHY xref.
         * Since we have multiple candidates select one based on PHY address.
         */
        ports = ofw_bus_find_child(node, "ports");
        if (ports <= 0)
                ports = ofw_bus_find_child(node, "ethernet-ports");
        if (ports <= 0)
                return (-1);

-- 
You are receiving this mail because:
You are the assignee for the bug.