From nobody Fri Aug 09 19:45:05 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WgZBV21vqz5Sm7Y for ; Fri, 09 Aug 2024 19:45:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WgZBV0sbqz4Rhd for ; Fri, 9 Aug 2024 19:45:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723232706; a=rsa-sha256; cv=none; b=pCp9z03l6Ms/UJPTIDDHJX/3PFBuoRm2Jd3kTHews8mgRnLHMA53WPY3NjJQ/e5qUZG170 FqBl6paUL/vZgue/YckL9ZHkXSE3y+cOUJ9VlyZqHA1kY5N/ABhs66AV6NZVoGKgLwW1MQ rQP2cV1/mxmJqh0s9Zylb4NHwRxwTWi02gEKjMFm9MKjo9fUgt4zOfThE5Ue3gB4rwJPa3 oNNmkPtVPe3jBV3Uhy+4wXBKfb/BURHXMK5pqDj+Sp15HIPQG5IyqUQdw/fotHeptck6Lv +jofmGfT3xCUyimwkiWw1AXtDzQVOjC9mxtylv8wZO5Wz8qC972ZyUCHwtNjHA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723232706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S3TFLOHK+Ny/QrPVnwWu/C4O7iZbF1UdRMMgJ/ZTHEM=; b=T0zM4IV316AxSbFC5UL/Ye4m8ARE6wkT1z1H2sOCLdqnBMRFxNIIYRRkdq65ooMRxTvm2v C8fgNLF8baMOy1zpfCBvx4fvJlMC2QHgT3llP3k582iql9zhk6UPoahuWxy+poeP0k4OxC 9B/HZar14wSeOwIkTILkHmjbOzBtoQEkoKlrTGOp4mYx8v5UvIioL1mfY3qNztQqCxOGTe FWI8xVnl5Nak3XR8e2SWMeXabBAcstsJjbTX8acQupMu830V3cViAVvgOoaITq4R3lTav3 7cCciq1DNusIeFyzKCiRNHu6Tvc+6JIEuP9UwIvZ3st8ua0rviEJ4p6wlxoueA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WgZBV0Q99zV3D for ; Fri, 9 Aug 2024 19:45:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 479Jj5AX071329 for ; Fri, 9 Aug 2024 19:45:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 479Jj569071328 for bugs@FreeBSD.org; Fri, 9 Aug 2024 19:45:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 280705] 0.0.0.0/32 is equivalent to 127.0.0.1/32, which may be considered a security flaw Date: Fri, 09 Aug 2024 19:45:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jhb@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280705 John Baldwin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jhb@FreeBSD.org --- Comment #1 from John Baldwin --- The change appears to have originated in BSD here:=20 https://github.com/csrg/csrg/commit/86fd50f180107b5998a451da64dd08668499e9f9 The context of these changes is that at the time, the broadcast address appeared to be all zeroes, and this series of commits was creating separate INADDR_ANY and INADDR_BROADCAST. Curiously, INADDR_ANY was previously bloc= ked by the old code in in_pcbconnect: https://github.com/csrg/csrg/commit/86fd50f180107b5998a451da64dd08668499e9f= 9#diff-947bd731f5c96a4641a584beac83dfcab5bac246a65cdba49fcf041bbb0ad5aeL111= -R121 It does seem to be intentional, and the comment documenting it was added a month later in commit 125629be4b7de3a379dee96a625a272271c0bb87. Given that= it was an error before makes me wonder if this might have been intended as some sort of compatibility hack? One of the other commits in this series is https://github.com/csrg/csrg/commit/b7aed1f9e438540acd1a66e07dd809fe8af34021 which added some similar logic in icmp_reflect(). That logic was later cle= aned up a few months later in commit 36dd422b2b80fd43eb60c920c2494858cded07b8 to= not depend on INADDR_ANY, and I believe that commit 02eb20c4604d7dad81aaa8cf7a96ef9f712f410d effectively blocked ICMP replies b= ack to 0.0.0.0. macOS Sonoma seems to also still support this behavior. I do think just removing the block of code in question is sensible. --=20 You are receiving this mail because: You are the assignee for the bug.=