From nobody Mon Apr 01 05:43:38 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V7Kgb13Yhz5Fd1C for ; Mon, 1 Apr 2024 05:43:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V7KgZ6r9wz4Wxm for ; Mon, 1 Apr 2024 05:43:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711950219; a=rsa-sha256; cv=none; b=uGrOSd30tjjXFP7orjkWEciitCQNtM2E0c+gs33BNHGLJXSvoNhTkt5zVslB9JdYKumxMj jEHL8rYqEclFIsgN1We1SqEHpymFItwzS6iV5CfhtIBUBAZrcuZ1UwGNsbNDTefFcvVGdw MiU54xZ4IHAM3mWxep5BeZFDCtQAs3gzu9bX/TawEECo3m0/Wuu96Z52//EL6zFsd9nTC8 1ZZsN/bYEQw+jcWBUsC2TEHm4AbNs+/3gZr1KJdOvZldiQBbdUDXhid5FsmgkiuOtko0Ub 0LyNoOIIey1Pz0yzbToRSKDAL3rGOZinI6WAsn8lKrw6ROhMRUijfa2AcL+GIw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711950219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QUM5Bd5B1I31Jrl0H6Ys4eKEGCyZ7LCZ0P5llUJRDTM=; b=nwUpT9qqK4Mh0VcuKZlUgGeCzJ8DFpkKnqU8avTgt0hXec42+nVp9rdTdXdLZQ0gsrZssU 5pKaLP9i1p4xluyE5NGUGKGnGrzo4JWXly9tFmZ5zVGUknYWUcZKWTwV5071FfsRrgob+y qztLyC0B0EtzOyM1mHdAeRC450l/ef7lyPXD9ijax+YXLaLYWcmgcDyFKYR3YuOX5NgeYd 65LZa5cVFSRPiTjqyvMzw8Fs1GYEQOIyUVidmdD8mGoPF0Vulx4g9LR3A7Z5vxOV9wzqOl 6cb2jE+QaAdjj2HjjZrQEPaPutAOo0Xj5gWcWl5R8J7OybKUxYXstYThHKWbFg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4V7KgZ6QFpz18bD for ; Mon, 1 Apr 2024 05:43:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4315hceg082781 for ; Mon, 1 Apr 2024 05:43:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4315hcgI082780 for bugs@FreeBSD.org; Mon, 1 Apr 2024 05:43:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 278087] qlnxe: promiscuous and allmulti modes not handled properly [PATCH] Date: Mon, 01 Apr 2024 05:43:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: keith.reynolds@hpe.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D278087 Bug ID: 278087 Summary: qlnxe: promiscuous and allmulti modes not handled properly [PATCH] Product: Base System Version: 13.3-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: keith.reynolds@hpe.com The qlnxe_ioctl() function checks whether the IFF_PROMISC or IFF_ALLMULTI b= its have changed since the last time the bits were saved, but it only saves the bits when the interface is marked down, so it misses some changes to those bits. Also, when it does detect a change in the bits, it always turns on th= ose modes (promiscuous or allmulti), even if the change was to turn the interfa= ce bits off. And, when the interface is reset (such as when the MAC address is changed), it doesn't check those bits, so it always turns those modes off e= ven if the interface bits are set. --=20 You are receiving this mail because: You are the assignee for the bug.=