From nobody Fri Sep 22 03:37:05 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RsHyB09HPz4vR2H for ; Fri, 22 Sep 2023 03:37:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RsHy96GmDz3XB3 for ; Fri, 22 Sep 2023 03:37:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695353825; a=rsa-sha256; cv=none; b=TzJAnRP03Nv5lKONU592gEvZH6HV9tVZteD3ANzmsCaqYnjmIB8LqLqxDG56SZL1SniZad ma5YxATDfV2AKXDfvSVZjfUFTEZfYlz5Br3/KQgDCAlH8yQAOEP+i9ApjNlr856Re+hp3L tWn6+SMm49pzzJr3dRU7MKxJs3GySw70m0PCT87ehlkTz/nypWc6aESjuxrQRCklkZEu8A uZorGh++Qlgq01EcgPODPCLJaDmkIKAkw0pF/gQ8SjFIUrRSediaTNZO5gDppqhX/RbbMX kgWEyxQMrCu/pFiOqaOv/3yPgWWSZuEvgLnPDPhXWM1CXqvfOQwPMM7s3Y+DKg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695353825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xJ/GhLjp8fNhlTLpqcg53fj5DnVt26OHDrZSzsQH0gQ=; b=RThG2cgqWNKR+/HKfg4EqjHsrvYiM/qXS/STIemAMqssGTMM3CWjYH23UjyXY73oqLiSa/ PuPllcExG7gSdrhPi6UOp7H7y6ujvfQzKsgCzJqFHRxlGttwLQ3anz+G6m1CChj0ogeO4x dYS/58UmRWKccoZl9Cbws/KwnCnxjgoa7m/R9FIodWE6EzpsUXqMquj19Ih/llNAUiQE0M i2jLh6a97Dylp9K/VMG/OZ4FIWGomwLFjSQ/RBXR5rw8naYQzrc/cDh7+J65HZHVOHy43/ kUhN74MbiGrL2N5jTQ5IXDJeKq0B+IjD6NDQufXqyWXpJJule8tZCQbVnkIlKg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RsHy95Kdlz15Nv for ; Fri, 22 Sep 2023 03:37:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38M3b593041000 for ; Fri, 22 Sep 2023 03:37:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38M3b550040999 for bugs@FreeBSD.org; Fri, 22 Sep 2023 03:37:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273418] [panic] Repeating kernel panic on open(/dev/console) Date: Fri, 22 Sep 2023 03:37:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-STABLE X-Bugzilla-Keywords: crash, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273418 --- Comment #37 from Konstantin Belousov --- devfs consumer is same. There was a trivial conflict. Below is the stable/1= 3' equivalent. commit e84128814bcdc854c1670447ba1525711736d7f9 Author: Konstantin Belousov Date: Thu Sep 21 13:47:14 2023 +0300 tun/tap: correct ref count on cloned cdevs PR: 273418 (cherry picked from commit 07fda41d2a2df0d0d422f30a8a2353de5f0d9c3e) diff --git a/sys/net/if_tuntap.c b/sys/net/if_tuntap.c index b81c2149a62f..bad09a3148b9 100644 --- a/sys/net/if_tuntap.c +++ b/sys/net/if_tuntap.c @@ -544,8 +544,10 @@ tun_clone_create(struct if_clone *ifc, char *name, siz= e_t len, caddr_t params) /* No preexisting struct cdev *, create one */ if (i !=3D 0) i =3D tun_create_device(drv, unit, NULL, &dev, name); - if (i =3D=3D 0) + if (i =3D=3D 0) { + dev_ref(dev); tuncreate(dev); + } return (i); } @@ -605,8 +607,10 @@ tunclone(void *arg, struct ucred *cred, char *name, int namelen, i =3D tun_create_device(drv, u, cred, dev, name); } - if (i =3D=3D 0) + if (i =3D=3D 0) { + dev_ref(*dev); if_clone_create(name, namelen, NULL); + } out: CURVNET_RESTORE(); } --=20 You are receiving this mail because: You are the assignee for the bug.=