From nobody Thu Sep 21 07:52:11 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rrnfz6FzRz4tk0s for ; Thu, 21 Sep 2023 07:52:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rrnfz5Flhz4JXY for ; Thu, 21 Sep 2023 07:52:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695282731; a=rsa-sha256; cv=none; b=iVVm/Q47lwLk7xlOSDoUcnOdRMfu3Ayc99P+oXrHcUUgAK2/YX3advSC2t0gyKKQcQ93Oz 7qKIMcq/8w79fSRP2hz8rhd6eBN9B6FLDtidOl5mwd1Nii+F7sdczI6gWwt12JYsk6Wq11 aLqxyiDDDwjPje7eNoxwj9zSB+Bb8jqUcUzH8KDnZI/Tk81O8Aqdyw1SNaYXmGhf3icsI6 dm3Y5MVb4jjkFfhR6DhrazhKyqi1C9GLsCl5TUEVmByupwok2q7GXbpBNnrE8sRmLCYAwH NDHCFaROsKUWuVnIZvN2Yhm3d5t2wGSUnIkiSLaE/7RGQE/8dmz1dq7HGfqQYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695282731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QaiL4mY/X/neTVf7IxKd1GQeuUo8NaXzs8AT9JxSM/U=; b=CVeAwO4gaI1GhkPzYofPGqUs/mP5pOjCLDDyXTKRrkZfEZUGGXiToV7UiTi1mP1poYLQzb rxQNSHet99bfHgPIoszb1P07DhcKcaL3bBwANrd/alQ/Esr8DKP3R/u7hdN0beZYyZit8W S00wUoRw61su8C9JkPXPgQhRld07AZJD4C9zsh+NZ5uukgdB8Zphb9RZLTGitm5tqksyir o+FYW2xuKdkbuJ5aZbIdWZhf7bOvrlUqtMHqzEpWy3v2Kp9Pr/o2de8fE/v2/+QWmRg2F9 jBBIrzJEOA8GI2X5Kn6eY2wBRi0sMCt9pktq1KibVUO1/zM2dEzJ3aUuUM8DnQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rrnfz4LTLzWMv for ; Thu, 21 Sep 2023 07:52:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38L7qBd7051435 for ; Thu, 21 Sep 2023 07:52:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38L7qB5D051434 for bugs@FreeBSD.org; Thu, 21 Sep 2023 07:52:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273148] [PATCH] scripted installs are unable to verify checksums for fetched dists Date: Thu, 21 Sep 2023 07:52:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273148 --- Comment #10 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc0e249d32c780ee8240fe8b3b8144078a= 8eec41f commit c0e249d32c780ee8240fe8b3b8144078a8eec41f Author: Lars Kellogg-Stedman AuthorDate: 2023-08-15 15:44:02 +0000 Commit: Corvin K=C3=B6hne CommitDate: 2023-09-21 06:41:48 +0000 bsdinstall: avoid conflicts with fd 3 Throughout the bsdinstall script fd 3 is used by f_dprintf (set through $TERMINAL_STDOUT_PASSTHRU). In several places in the bsdinstalls script= s, we use fd 3 to juggle stdout when calling out to other tools, which can cause the installer to fail with a "Bad file descriptor" error when f_dprintf attempts to use it. This commit replaces all constructs like this: exec 3>&1 SOME_VARIABLE=3D$(some command 2>&1 1>&3) exec 3>&- With: exec 5>&1 SOME_VARIABLE=3D$(some command 2>&1 1>&5) exec 5>&- PR: 273148 Reviewed by: corvink Fixes: 1f7746d81f53447ac15cc99395bb714d4dd0a4da ("bsdinstall: stop messing with file descriptors") MFC after: 1 week usr.sbin/bsdinstall/scripts/auto | 22 +++++++++++----------- usr.sbin/bsdinstall/scripts/fetchmissingdists | 6 +++--- usr.sbin/bsdinstall/scripts/hardening | 6 +++--- usr.sbin/bsdinstall/scripts/jail | 16 ++++++++-------- usr.sbin/bsdinstall/scripts/mirrorselect | 12 ++++++------ usr.sbin/bsdinstall/scripts/netconfig | 12 ++++++------ usr.sbin/bsdinstall/scripts/netconfig_ipv4 | 6 +++--- usr.sbin/bsdinstall/scripts/netconfig_ipv6 | 6 +++--- usr.sbin/bsdinstall/scripts/script | 13 ++++++------- usr.sbin/bsdinstall/scripts/services | 6 +++--- usr.sbin/bsdinstall/scripts/time | 12 ++++++------ 11 files changed, 58 insertions(+), 59 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=