[Bug 273902] Backwards-incompatible size change in struct tcp_info

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 17 Sep 2023 14:19:06 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273902

            Bug ID: 273902
           Summary: Backwards-incompatible size change in struct tcp_info
           Product: Base System
           Version: 14.0-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: kern
          Assignee: bugs@FreeBSD.org
          Reporter: asomers@FreeBSD.org

struct tcp_info, which can be retrieved via getsockopt with TCP_INFO , changes
between OS versions.  However, the struct has a fixed size for
backwards-compatibility; a program compiled for stable/13 should be able to run
on stable/14 and successfully retrieve the struct; it simply won't know about
new fields.

Unfortunately, two recent changes to main accidentally enlarged the structure:
945f9a7cc9dcc071bfcc702748fbbb11087ae773 enlarged it by 12 bytes
22c81cc51636cfebe94e0979eb31556d87775938 enlarged it by 4 bytes

Meanwhile, two other recent changes added new fields but were careful to
maintain a fixed size: dc485b968ddeb and 3708c3d370f26.

We should reduce the padding field to compensate, and MFC before 14.0-RELEASE.

-- 
You are receiving this mail because:
You are the assignee for the bug.