From nobody Thu Oct 19 21:24:14 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SBLM23Zcvz4xtkc for ; Thu, 19 Oct 2023 21:24:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SBLM20X2Zz4MJ2 for ; Thu, 19 Oct 2023 21:24:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697750654; a=rsa-sha256; cv=none; b=So2Y8lNjvQPt5s0xs+lbA8xW7oBTsh+Ab+wKRW70WltkThhuPcRsyCPSTLkCg04y4fxSKv EAvN9UXWGaGxloQf8b52Dwp0un3v/A5Ml6nqVf56zuQKIpuzFYYTwAF90V9yd5hQMPrwnn s1BGEYtYTUShFpmqmKnww3VzLGspSeStTA/X0ArUisnm9c4ahbZgcGjg4DNAXDTEaS9v+l 2ef5Q8CSQGWj49UqqbeA9upUdYT3jzcSL6+QMI5H57cRlh93Btmbr7icnlhq8jJiBx61bE GzSXiQ5cSqKXftBG3V8bNJis/bsbYuN2kGFTCs1QZrIIU9SbMmJUwhC8ssCnDg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697750654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uDTcMvUIum732dR6DvC4ypXCAY62XXxSH05P2xw+unc=; b=JGiwT0vgxQnAuDNlqbywdcJqwrug8WEdnVVv2ral7j0vdZ1KWXPK28vcbrhN9lYEb55iF4 26jEo+mz2Hp7KSP0aKbwMBooSYAOR305+FvNtBZluUOjBX9J/bn0nemWfhym8/JHj4EJpz xcTXA2oQj4YrJ9Y5VXv6zbkb5ogVZaYrLI/wt2mdfBX9d1ozzK0Hb8h6525LuaOFOh1hmJ 6G5CjGftUYyVqLrOQ1xqTJ4mFWR9f9+4afLDXXkld3P9trKkDPfuZI/SRPafHVo7fZefqN L1JPY9d64OAf1gJbyCoUCDzZOc2I7GxabA7GsBaEYNDEPNC3Didkj68LrcFhww== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SBLM16jRWz15Rr for ; Thu, 19 Oct 2023 21:24:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 39JLODGB001087 for ; Thu, 19 Oct 2023 21:24:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 39JLODOv001086 for bugs@FreeBSD.org; Thu, 19 Oct 2023 21:24:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273289] smartpqi: fix panic on removal of SAS drive Date: Thu, 19 Oct 2023 21:24:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-STABLE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273289 --- Comment #16 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D1ad148a68ae74f3372b12b6e66fadf5ad= e384144 commit 1ad148a68ae74f3372b12b6e66fadf5ade384144 Author: John F. Carr AuthorDate: 2023-10-19 03:25:31 +0000 Commit: Warner Losh CommitDate: 2023-10-19 21:21:11 +0000 smartpqi: Drop spinlock before freeing memory pqisrc_free_device frees the device softc with the os spinlock held. This causes crashes when devices are removed because the memory free might sleep (which is prohibited with spin locks held). Drop the spinlock before releasing the memory. MFC After: 2 days PR: 273289 Reviewed by: imp (cherry picked from commit b064a4c9eed5b1dd2a40fc4fd2cb7e738b681547) sys/dev/smartpqi/smartpqi_discovery.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=