[Bug 274454] usr.sbin/syslogd: closing a configured terminal in parse_action(), line 3057

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274454

Jake Freeland <jake@technologyfriends.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jake@technologyfriends.net

--- Comment #3 from Jake Freeland <jake@technologyfriends.net> ---
(In reply to Trond Endrestøl from comment #0)
Hi Trond,

I'm not really sure what you mean by "made /dev/ttyvb inactive".

A TTY descriptor is only opened in parse_action() to check whether it is a
valid tty using isatty(). That descriptor is closed because it will never be
accessed again.

See
https://cgit.freebsd.org/src/tree/usr.sbin/syslogd/syslogd.c?id=a5ed6a815e38d6c622cd97a6020592ded579cf7a#n1973

When a log message is sent to a TTY, its path (saved in f->fu_fname) is passed
into ttymsg() and used to reopen the TTY under a new, temporary descriptor.
That original descriptor value (f->f_file) is never actually used.

Did your patch fix the issue you were facing? If so, there is something I am
not seeing here.

-- 
You are receiving this mail because:
You are the assignee for the bug.