From nobody Sat Oct 07 02:49:45 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S2VBf1Wb6z4wYJh for ; Sat, 7 Oct 2023 02:49:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S2VBf0Tknz3Lcq for ; Sat, 7 Oct 2023 02:49:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696646986; a=rsa-sha256; cv=none; b=j7UsVLW+QkcUXeaeHkaMPiKDXVS+4VFtT9bWvbSY8qvv9+8x/xaHhul+LGhmfJECHVDc0R my4qh6xsCuPAwyoSM5fOTZlocCh5iILHAYyWtmNM3f4UeFaUYSf/HkzfpvQlhOw11FLGc1 7O/Ulv3inNcESvdRF2/lNz+4S9ztSEbqYbYXwCFGkRD4olDRU5STiT8kb8zQ9Y/9pI5SFH 4+jnSzyd6lej+P1KQPEAoCZKCUFcI7oJnQxIOP8fePaHRPmbDZHE2iPM4wUnnbhW+Bo8e4 2tcNdL2IwVa4fSE7ddktRGaJImqINNCRjGm9uqBvEvx7tWSdCQYU2m5llmmRcw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696646986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9QRLrMTq9VjtIQa87KTOz5BhSSuoi/odpDjAiE7PObw=; b=eYd6gYoQTQEFNwqRnux3BIeAynFVlA7AAoeI2HYQz99IH/S4muHQisbi5vV5zUdsgpcYja kbSIKz/4PvWE1rw7LdelysOMaW+hhVH4AfuFV9F59CYm6eXauh9ZgDzRWMkWPe+pIQQx4v i9LjWOIyPRPhpQPFrU3VCzp7Xtxv+m0dnv3DXjk7Fkc2a1pKldjnAIw5y5dUPh7m881R9g nUiNxZLNwQoPDWpXElpopRIo88MSykjUl2g/bMFwkIahTYlo+okiUjrOdV8dyw4hbnSvtj aTeHrRidaWiOoieabzSHmxaJvRzJczdGmaXkMnjXMR+C09TYUbLJyJsHXtXTBw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S2VBd6h1rz1CS0 for ; Sat, 7 Oct 2023 02:49:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3972njTc092419 for ; Sat, 7 Oct 2023 02:49:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3972njWU092418 for bugs@FreeBSD.org; Sat, 7 Oct 2023 02:49:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273902] Backwards-incompatible size change in struct tcp_info Date: Sat, 07 Oct 2023 02:49:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273902 --- Comment #3 from commit-hook@FreeBSD.org --- A commit in branch releng/14.0 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dd67558ef3149c02223fd15206c8c7766f= 6891be2 commit d67558ef3149c02223fd15206c8c7766f6891be2 Author: Alan Somers AuthorDate: 2023-09-17 14:22:08 +0000 Commit: Alan Somers CommitDate: 2023-10-07 02:48:17 +0000 Fix padding in struct tcp_info This structure should have the same size across different FreeBSD versions to ensure backwards-compatibility. It has since stable/6. But two recent changes added fields without compensating by reducing padding: 945f9a7cc9dcc071bfcc702748fbbb11087ae773 and 22c81cc51636cfebe94e0979eb31556d87775938 . Reduce padding to compensate. Direct commit to stable/14 because we decided to break compatibility in FreeBSD 15 in order to add more fields. Of course, that decision could be reversed before 15.0-RELEASE. See the review for details. PR: 273902 Reviewed by: tuexen, glebius Differential Revision: https://reviews.freebsd.org/D41894 Approved by: gjb (re) (cherry picked from commit 2209676efe9a23d9411fa0314b9c6bb285baefc1) sys/netinet/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=