From nobody Wed Oct 04 14:37:15 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S0y2M5Yhqz4w31X for ; Wed, 4 Oct 2023 14:37:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S0y2M2TDQz4F6m for ; Wed, 4 Oct 2023 14:37:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696430235; a=rsa-sha256; cv=none; b=LSrbesvWx/MgUBSinlyKcaB1Q3lL4Lk0s11B+lDNvcY7JMaRRmx0f2kEahtRyP45Oyt39q S9uOOWAKbnqrXlz8Ayj3pXYAdXhmvabfmNKElD7mA5oIAKafCkc0k2ALNhrmWXUutCI17R n5p+uSJ7GdA06euWZC47yTnBcWewRCzEOoy8akPoIzRLSarbBzA/KE13gSf5sIQ+jKuP0A XJEXUQJthUBTFeE1TwtGZNx1vlzLH8cj8x5c9r8ZHm+JctoV6VMEJXM7JE1EUYS6HsfoS8 k5R4v7S9y8ZD7wiE0BWXe+rvU4fz0U9I5fTl9DchBp3g6NualybqTLeU89dGnQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696430235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zpo9IhsOJZuXvf44BMAbbqFHzWKhdAVCXoTo5dzk92Q=; b=waLTB9x0TRjG1B9xQHED8fQNA6YxdS3vZ3BrajH68dCx5BWuH5pamyeVaPq5hSkd8DhnzB 0BkFEvOoUTwCfC5yOdOZs9S+Zmp21THTn/Qbw6BUfXul2uhx5ApTyNLBdvfn4VB9IpWckE jmTRK8lX2Np493g4199kRbBdvQgpvBgrJ9iP1yzhJQNljZu7ZsGyMWWEJUAxUtVtFtvQXC r+HqiUBchWLG6ZKxoh6SThD5BsEuzMnhty0RW2qAP/EvG1wA8T/mH6BBiIHWLPfDpJpTd0 PSdpwoZTp93KIovBZxVXeJZYMTMa4hbmB4yjQFJldbojtRML4R0vSpAFNrdNUA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S0y2M1ZCBzhPJ for ; Wed, 4 Oct 2023 14:37:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 394EbF35061591 for ; Wed, 4 Oct 2023 14:37:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 394EbF6M061588 for bugs@FreeBSD.org; Wed, 4 Oct 2023 14:37:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 274198] ktrace: logs only one arg for symlink() call Date: Wed, 04 Oct 2023 14:37:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274198 --- Comment #5 from Mark Johnston --- (In reply to Dmitry Chagin from comment #4) I am on the fence. I agree it is weird to use NAMEI here, but as Ivan poin= ted out, ktrnamei() is already (ab)used by shm_copyin_path() and vn_getcwd(). But, the symlink target is not accessed by the kernel, and the symlink targ= et can be an arbitrary string, it does not have to be a path, see malloc.conf(= 5) for example. So NAMEI really isn't right. I think KTR_STRING is probably a better solution; I would extend the KTR_STRUCT flag to include strings. --=20 You are receiving this mail because: You are the assignee for the bug.=