From nobody Sun Oct 01 15:37:58 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rz7Wq0YyNz4vSpf for ; Sun, 1 Oct 2023 15:37:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rz7Wp6W89z3GZH for ; Sun, 1 Oct 2023 15:37:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696174678; a=rsa-sha256; cv=none; b=hKBd52dEfp9SaHPNoW0idnoud+Aixo5vK6WVr5w003NAzAMOZGFCWpJlqnw1Us/WZK+7K+ pHmJ8YWhEH6XO9SbnuXGiC1yuIqyu8lQdTrC5toOxPQAiUDKvdLs54p1sMoMn+xz9yPUrU rmbu5HFuVZjZHgXEyrdKb21DjLRNPnUiecuszNrYEADQtsOsGBhTH1RT2oeLsvbb8MakE8 OB4z7/Fu+d4opRteMYG4X2SMDYIfAgeTIUV+Y05FkHqoJFgvKzt8UVfug42z5eBA2N+YXF uQQWQH9VstmflyMmLNkq+4e71hhLAn3OT2ghEUQaaNNyqPKbw6esbpXjE2uiVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696174678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dqgTOhVDgJqH2IveWrgmc1O7x2ehlGI0vXJspERN7P0=; b=QZbIaODbPJSG1DrCzntKFYRuF3UTVVDAlKB6EonGHbvoq3nSFy0SP0TvUGR9OI/JSeQt8b T0bySSMep49KmzzgWP+kdVRN3Cqn5IYRBeClN7cC0J75KDlLI8FuYUexBH8HgS3c5U2rqu O8ertwMNxbXe7RYvvo/hQFpQ0Iljr8XsGdjxQMqn0/le/RMWy5ESixGBRqaB7ypAEGl4Fw SbOBlw1mcWk7+/GRyfwW+D9Szie+cb4GpYkD2vRqBSHmEEu4GCShw/D9PYX+LlFDTJnXxM qWsTcqyR9nf4tIxLT3bOJ64hTgahtojBpDDiTrP2+LYs87fBj3QlYeBACo4FKA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rz7Wp5RggzZpm for ; Sun, 1 Oct 2023 15:37:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 391FbwOr061725 for ; Sun, 1 Oct 2023 15:37:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 391FbwIS061724 for bugs@FreeBSD.org; Sun, 1 Oct 2023 15:37:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 274014] hmt.ko kernel panic - Asus Expertbook B5602 Date: Sun, 01 Oct 2023 15:37:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-STABLE X-Bugzilla-Keywords: crash, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274014 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markj@FreeBSD.org, | |wulf@freebsd.org --- Comment #1 from Mark Johnston --- Here we're crashing while parsing a HID report descriptor, it looks like the descriptor is invalid somehow but the driver isn't doing enough validation: 753 if (hi.collevel =3D=3D 1 &&=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 754 hi.usage >=3D HID_USAGE2(HUP_BUTTON, left_b= tn) &&=20 755 hi.usage <=3D HID_USAGE2(HUP_BUTTON, HMT_BTN_MAX)) {=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 756 btn =3D (hi.usage & 0xFFFF) - left_btn;= =20=20=20=20=20=20=20 757 setbit(sc->buttons, btn);=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 758 sc->btn_loc[btn] =3D hi.loc;=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 759 if (btn >=3D sc->max_button)=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 760 sc->max_button =3D btn + 1;=20= =20=20=20=20=20=20=20=20=20=20 761 break;=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20 762 } In particular, we don't check that "btn" is in the range [0, 7]. I'm not sure if this means that the descriptor is invalid or whether we're missing some special case? --=20 You are receiving this mail because: You are the assignee for the bug.=