From nobody Sat May 20 21:37:32 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QNxrX5kctz4BYgZ for ; Sat, 20 May 2023 21:37:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QNxrX3lhjz4FNQ for ; Sat, 20 May 2023 21:37:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684618652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5XWH96msY7vpIKcgJA8QBBLAIIM/Jbk5YZpPltmjsbI=; b=KZrwpXU2q3IapTTTir0qy3odiFYSvj0Yj6mr/be/ImmpUrA/LIp6BlJSsyEEYmaehsaYG9 HN5Xm9SY5SkaVd42lXEc/4NJ0dr4ebxXgqIxUH2m5P5y54051/yp8KlGbfHso1nlMQ6MUU ig8/aSX7DdQky6q8m18Cv4IIck2ciwYPZF2lWtmGhlowaP6cfh2k2QUgwAA6zhoz6UTbLy k+kH/7TJTtDZ3IgFLZrIFmtHJukV9J5w0cNxqF8D8ELm4oN6Xcm2nDew8kfTcVohaipoY/ XThkaSPMoysLzYaBeFOEKyYROLb20dErp370IeuaBTjfZTuM2AYXYXmcTM2JiA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684618652; a=rsa-sha256; cv=none; b=qv6Q0ovxQCtvuZ5gMXqGaKVpjmE4+QsuzVV4hD8q3GEaKanHXVM9mI3tYhl9RVzZSA0vQs 7CpY9W6hhbXf2RRPK0IZ1hugSTCBq3H62UQSo6M2DZirEtrxFfVyLGunziB51joJ8FaX1r hL/S2ODPmkZn9sEhQAxDmxrXtrYo/e678DETfasqdeDsU8S6aPSPvHAe84JFfCOwTUBo5+ Tg62/ojJXt8DTrNiAfXs8idU6cTt5vglpl12iR/R+FdvT7ryuIOJFySRfSZs9+A8dtSp3R gOIRZ83MtZeNk6yBt7ePT1AHA8VS3vh1zG/LpM9XidibYlXXoIqJGlyeKtbH1A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QNxrX2rpMzQXc for ; Sat, 20 May 2023 21:37:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34KLbWov068427 for ; Sat, 20 May 2023 21:37:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34KLbW4i068426 for bugs@FreeBSD.org; Sat, 20 May 2023 21:37:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 162373] VESA framebuffer memory mapping fails with EINVAL for certain modes Date: Sat, 20 May 2023 21:37:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 8.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: J.deBoynePollard-newsgroups@NTLWorld.COM X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D162373 Jonathan de Boyne Pollard change= d: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.deBoynePollard-newsgroups | |@NTLWorld.COM --- Comment #3 from Jonathan de Boyne Pollard --- This affects more than just 1 person. The suggested fix isn't quite right. The simplest fix is to just take the = "- PAGE_SIZE" out. The page maps are set up to cover the whole buffer, in fac= t to cover the largest buffer size in any VESA mode, and va_window_size is the r= ight field to use. There's a similar check, with a similar query, in the VGA driver. That's n= ever been questioned probably because the VGA memory windows are usually a whole multiple of the page size. Applications programs have been working around this for years by rounding va_window_size down to the next lower whole multiple of the page size. But this is at the expense of their being unable to memory map a number of pixel rows at the bottom of the screen. --=20 You are receiving this mail because: You are the assignee for the bug.=