[Bug 260248] jails: depend parameter does not work in modular jail files (conf.d)

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 08 Mar 2023 15:21:01 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260248

Mark Felder <feld@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |feld@FreeBSD.org

--- Comment #4 from Mark Felder <feld@FreeBSD.org> ---
(In reply to Antranig Vartanian from comment #3)

I've tested both cases and they fail. If you run it as

sh -x /etc/rc.d/jail start JAILNAME

you can see what it's doing.

At no point does it attempt to read in any other jail configurations before
processing the target jail.

This is a bit of a chicken-and-egg scenario as the code handling the startup of
jails is shell script which guesses where the jail configs are, and the actual
processing of the jail config parameters is done by the C code. A bad hack
could be implemented in /etc/rc.d/jail to actually read the contents of these
files and look for a "depend =" or "depend +=", parse it, and then try to load
/etc/jail.JAILNAME.conf or /etc/jail.conf.d/JAILNAME.conf so it can be merged
together and the jail will be discovered. However, this opens a new can of
worms as there won't be any isolation of configuration between the jails and if
the configs are simply concatenated together to be presented to jail(8) you
will have issues with one jail config declaring settings outside the JAILNAME {
} section and leaking into the config of the jail that was appended.

The correct way to solve this would be to move more logic into jail(8) so it
does all of this work for us and /etc/rc.d/jail is stripped down to simply
passing start/stop/restart commands to jail(8) similar to how docker works.

I will gladly contribute to a bounty to overhaul jail(8) if anyone out there is
willing and capable.

-- 
You are receiving this mail because:
You are the assignee for the bug.