From nobody Fri Jun 16 18:59:29 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QjT3j5bTcz4fWC8 for ; Fri, 16 Jun 2023 18:59:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QjT3j4YTVz3vJl for ; Fri, 16 Jun 2023 18:59:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686941969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KhWl/5emiCoEhYMhXkAO/v9M3GctNiDlyZjWV53aFlo=; b=MshWjcgoqRMRakd3JViaTQA43rA4yjelOSTkXb1E0b/RGXWeCB0A5bY0JHGd5KJ+dy5Uzo jL8oxm+Sa+aZyaY84rZHFxoPvbsAJ1KsH7nByxXRaeLpbWmGnHVbyXcWywhJjZiz3PTtgi 1gzfKkSh+R5AcRYnM7eHtUdclES23M9A8XvXYplmA2hqGxuXlfU8tIIVrfza9Cn9B7PlQc +v8M2qHErhL1UJpVZE00kq/nTnVd7MoAftaDTq7JuVlnTNRqnwmreKRrDjMn0ZeSNfBRZ6 NR4euqYgtVSK3SBuuugWFGmxnF7QET+4WVKXQei22740fdCdHdqkOoS4IhyGFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686941969; a=rsa-sha256; cv=none; b=ywSbz2mzptLN9wsFtfPlBTIC0Ph98xpBJStqDxH+MfgLRhYVe2OBoKstRepQMPvTeAHhG9 K4x97uqsTYkehO+UMBy/bN1Mk1mtjukY4N8CPAJBAoQFUnxLKad6Ev2r8p2gIKxuA+EpMN PlecDROBLmtcNqXEKGzNm9pJFqY+/WgVCuGSsVHrQ/n1BL7J67a3IRQPMBocZip/ltmH5e QwTZTmMWjGliCgoH1BKFiWX8TNe4NhujlpR30XwsqLP93r8vMlcJSGmZ91A4WZP+vFInR2 nhH3ptpLG/V8Y2UzlhAHSiUcNBFO5ZTeziTot8ipSvAW/oPKza+8ytYCh5OUfQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QjT3j3bW9zflV for ; Fri, 16 Jun 2023 18:59:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 35GIxTQd095521 for ; Fri, 16 Jun 2023 18:59:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 35GIxTf0095520 for bugs@FreeBSD.org; Fri, 16 Jun 2023 18:59:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 271991] Crash on some network packets with fresh stable Date: Fri, 16 Jun 2023 18:59:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271991 --- Comment #5 from Mark Johnston --- (In reply to Ivan Rozhuk from comment #3) I don't think m_pullup() is the right layer to handle unmapped mbufs. It g= ets called very frequently, and mb_unmapped_to_ext() is expensive even when it = does nothing, since it has to visit each mbuf in the chain. (In reply to Ivan Rozhuk from comment #4) The patch to m_pullup() assumes that "m" is mapped, which might not be the case. Hmm, virtio-net does not set IFCAP_MEXTPG, so the protocol layer will map mbufs. This is actually rather suboptimal, and the virtio driver should le= arn to handle unmapped mbufs. e1000 should handle unmapped mbufs though. Do y= ou see "NOMAP" in the interface flags as reported by ifconfig? (In reply to Ivan Rozhuk from comment #0) It would be useful to see output from 'p/x *n' in frame 9. I think it wouldn't be too difficult to make bpf_filter() work with unmapped mbufs. m_xword() and m_xhalf() would need a bit of special logic. And I t= hink ng_bpf() doesn't need to do this pullup at all unless BPF JIT is enabled, a= nd that's not even compiled into GENERIC. --=20 You are receiving this mail because: You are the assignee for the bug.=