From nobody Fri Jan 20 19:29:17 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nz8gx6X8Sz2v5B5 for ; Fri, 20 Jan 2023 19:29:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nz8gx4bqKz3G2H for ; Fri, 20 Jan 2023 19:29:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1674242957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TNwxe4qq/xb2rze9IDcjVXP6FF32xPPNptBM1s4p8xQ=; b=gUNl+6I8NA3VaRpusnVDX0biAdhoCGegSuTM8mZjgsUdkguK4wucilJ7625C+juCRDD50v aA4aeT526eMfPTfUhdve69pXypTHjhriY8KxcRoRsAKRohaMfjTVo+EyFICYktaFoUoiBb JNXXtCsW0hQdQDaFn4Ew8sU+m5QYAm2Ia6lWT/AA8k7p6dS59FVkwsIhcJXMy2Phi1Zzkg TCbgv62bczRNVcCZJ1ZueQP6UFzscNoSJN6JTT/8nNQtHlVmAANM9YslvX9/7BXS0YBvtl c2UED1h5RApx3AIPvBAMDACex6zS3+b/6TgrpnABgRZjemGUYCvEgJ/RZX8PdA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1674242957; a=rsa-sha256; cv=none; b=KXJkBsMOImOvtAcckaD27qDNHeM+gbf82rJsX9Ml6LbqACM1RsP9dKmaWBiDXTRnLSCZxF j6jYz3rbBoGMXeuKuty7KO4T/POYX7qhp9InD71qytopAKmB4QLUMMITxUf/I6YZYbN1FB Vr+pBRBceiOY8FqKUOZQWoH4WH+wnkE588Oxp3FpXZHOUbMOqKV4/8FZQeBhNgzhoH3sH0 pmDnrhf2OEit2u65K/ilPHZjf9jkvYZ3XFbV9BAMI9fE17gEVqhN2vl1vuEEDwG84KoKYW 33QyPgRb1b6ctGAHoQ223yFhWDHz+53ZlVIQ+/Tk8GaMm+3KRZi4Xk4bh/mQrw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Nz8gx3hfFzhln for ; Fri, 20 Jan 2023 19:29:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 30KJTHZj081649 for ; Fri, 20 Jan 2023 19:29:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 30KJTHsZ081648 for bugs@FreeBSD.org; Fri, 20 Jan 2023 19:29:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 269075] pfctl and ifconfig invalid if statements Date: Fri, 20 Jan 2023 19:29:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: nreilly@blackberry.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269075 Bug ID: 269075 Summary: pfctl and ifconfig invalid if statements Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: nreilly@blackberry.com sbin/ifconfig/ifieee80211.c in printmimo() for (i =3D 0; i < IEEE80211_MAX_CHAINS; i++) { if (mi->ch[i].rssi !=3D 0) { r =3D 1; But rssi is an array so the if statement is always true. Suggested fix is: for (i =3D 0; i < IEEE80211_MAX_CHAINS; i++) { if (mi->ch[i].rssi[0] !=3D 0) { r =3D 1; There are similar issues in sbin/pfctl/pfctl.c in pfctl_show_rules(). There= are two instances (lines 1312 and 1366) of: if (rule.label[0] && (opts & PF_OPT_SHOWALL)) labels =3D 1; But rule is a two dimensional array so the if statement is always true. Suggested fix is: if (rule.label[0][0] && (opts & PF_OPT_SHOWALL)) labels =3D 1; --=20 You are receiving this mail because: You are the assignee for the bug.=