From nobody Thu Feb 23 01:25:22 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PMb1b12G5z3skMk for ; Thu, 23 Feb 2023 01:25:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PMb1Z73s3z48tj for ; Thu, 23 Feb 2023 01:25:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677115523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oxgdypgojpexNL35u2fl4jinirs/vhP9TWxE3HIul6k=; b=m5fAFK7/adjl4n1pmw1J2L3delQkXavJlYDtgHX1J6ygufO4EqZd3uZ5GMxBSf5+J/+arW 1XjmbedTVEQyGCUJB4eW6Ac4BUFwRh0WwTwTk6h91dYca439FrDO9V4BkVXQr61eRQnC1H k5uyAliXxI+rTkPxvvOJit9ywGUgSFv9pX8XBzvBdCyBSFR1VYEGl+xYFtA9H2PG2cQRXD YB0EjuMcQbmtsg5KfT+q4d1TAUdG17/OABc6LiLgneFmQRF5XAdoavvbRRazrVqH8UZsBf E0yANETBfSQ1T01gGLiLOF+NULPTB35H0bNA+L+HXlwnVI+hcYIVucS0LcxG0w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677115523; a=rsa-sha256; cv=none; b=kA4/AScWiriwv0xDkAp+Ua6wivad75yQ4ZoQhlZ0shYIhLduCp7e3NuCvNDWCRW7TlkunK sB2ZIIkN6eKX1HPKEvvDph7KI+IgVqBGEwRsijH2C00oH35Yt2hWHyuDf+NGCZhZjgV2Ed +xga4yi8gUquybmHpEUitOqyqRfaArZb2SzfndmiqEXKiNbWlEFf+3ZZ1xZHQa9EwEKkVh YGlbeqhHtehP/YuGPxpLc5p3mxNL8c1xLF5bhwBnzjdrq4Aieo+r971Fjy+7CH1uS//cXP Y79eKw0MoszMbgzaYw4/gPrpznO9g8uV/G0htu1G9lY+7xeLmEhsmg//s7Y56A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PMb1Z5lWQzNm3 for ; Thu, 23 Feb 2023 01:25:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 31N1PMrm018271 for ; Thu, 23 Feb 2023 01:25:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 31N1PMeB018270 for bugs@FreeBSD.org; Thu, 23 Feb 2023 01:25:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 266315] linuxkpi panic after recent updates (13.1-STABLE #0 stable/13-9cbba5950: Wed Sep 7 23:42:41 CEST 2022) Date: Thu, 23 Feb 2023 01:25:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dufresnep@zoho.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D266315 --- Comment #44 from Paul Dufresne --- (In reply to jakub_lach from comment #35) I searched: i915-userptr-acquir and come to this patch: https://lore.kernel.org/lkml/20191010083524.098009692@linuxfoundation.org/ With that patch: Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=3D203317 Fixes: 5cc9ed4b9a7a ("drm/i915: Introduce mapping of user pages into video memory (userptr) ioctl") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin Cc: stable@vger.kernel.org Reviewed-by: Tvrtko Ursulin Link: https://patchwork.freedesktop.org/patch/msgid/20190708140327.26825-1-chris@= chris-wilson.co.uk Signed-off-by: Sasha Levin --- drivers/gpu/drm/i915/i915_gem_userptr.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem_userptr.c b/drivers/gpu/drm/i915/i915_gem_userptr.c index 05ae8c4a8a1b6..9760b67dab28b 100644 --- a/drivers/gpu/drm/i915/i915_gem_userptr.c +++ b/drivers/gpu/drm/i915/i915_gem_userptr.c @@ -691,7 +691,15 @@ i915_gem_userptr_put_pages(struct drm_i915_gem_object *obj, for_each_sgt_page(page, sgt_iter, pages) { if (obj->mm.dirty) - set_page_dirty(page); + /* + * As this may not be anonymous memory (e.g. shmem) + * but exist on a real mapping, we have to lock + * the page in order to dirty it -- holding + * the page reference is not sufficient to + * prevent the inode from being truncated. + * Play safe and take the lock. + */ + set_page_dirty_lock(page); mark_page_accessed(page); put_page(page); --=20 2.20.1 Need to find where the equivalent for us is and see if it is applied. --=20 You are receiving this mail because: You are the assignee for the bug.=