[Bug 273414] linuxulator regression in symlinks under zfs
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 273414] linuxulator regression in symlinks under zfs"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 29 Aug 2023 08:54:31 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273414 --- Comment #2 from Dmitry Chagin <dchagin@FreeBSD.org> --- here it rather makes sense to speak about regression in vfs/namecache/ufs due to the fact that: 1. starting from https://cgit.freebsd.org/src/commit/sys/kern/vfs_cache.c?id=739ecbcf1c4fd22b5f6ee0bb180a67644046a3e0 file systems should cache symbolic link targets on their own. This method is not implemented for UFS, so the described bug does not occur for UFS. 2. UFS currently does not use namecache at all, so this bug does not occur. See here: https://reviews.freebsd.org/D41337, https://reviews.freebsd.org/D41338 I think it would be correct to modify the algorithm of the namei() and cache_fplookup() functions so that file systems are not responsible for caching symlink targets, ie, cache_fplookup() should stop its loop and return PARTIAL in case of a symbolic link, and namei() should resolve the symlink and go to the cache lookup starting from the current directory. As a temporary fix, try this patch, please: https://people.freebsd.org/~dchagin/vfs.patch -- You are receiving this mail because: You are on the CC list for the bug.