[Bug 229719] src/lib/libpam/modules/pam_krb5/pam_krb5.c:536]: (style) Suspicious condition

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229719

--- Comment #1 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=acc7cf8641dcedad295ff0e569c3f3a28939ada0

commit acc7cf8641dcedad295ff0e569c3f3a28939ada0
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2023-08-04 16:08:21 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2023-08-04 16:08:37 +0000

    pam_krb5: Clarify a loop condition.

    The closing parenthesis was in the wrong location, so instead of assigning
the return value to krbret and then comparing it to zero, we were assigning the
result of the comparison to krbret and then comparing that to zero.  This has
no practical significance since the value is not used after the loop
terminates.

    PR:             229719
    Reviewed by:    cy
    Differential Revision:  https://reviews.freebsd.org/D41299

 lib/libpam/modules/pam_krb5/pam_krb5.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.