From nobody Mon Oct 31 08:06:00 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N15Lx0vD2z4h2TW for ; Mon, 31 Oct 2022 08:06:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N15Lw5mtQz43MM for ; Mon, 31 Oct 2022 08:06:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N15Lw4RhSzT97 for ; Mon, 31 Oct 2022 08:06:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 29V860ZW066327 for ; Mon, 31 Oct 2022 08:06:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 29V860H4066326 for bugs@FreeBSD.org; Mon, 31 Oct 2022 08:06:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 267457] missing array terminator in netgraph's ng_bridge.h Date: Mon, 31 Oct 2022 08:06:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rtm@lcs.mit.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.mimetype attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667203560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1VB9FwUDuopb1XM8IhFBTlhcY/IARnEb19+rX2PH1Kw=; b=ZMi2vTWslBzvYM54TnF08ivcwQ839Yqz2kCXV+7csvk9Mmjs3OLUS6+Wg68FpciO87tLvs KAc0xyZ6eQtS0QAS5zapkA5Cw4YGyHobOBMd16eIUnAcEnKrJ53cuyBDa3JX5cGsYMHGgS e4IjQrS+XLlTXuunC4QscuJ/Ufb/rPciVv6UaCjEJa/b16vkohBMauYO/AewmR2+DGpILR 3DdvXdsL+ifkLi5mlu8yOriw2Pz8NQtA1+WZcouoeyShApllNaeVlZE9kaTtSNvmJ7QFs2 sdurIPApntZYOvWXxTouSDO7pyR3WwvVPyGchh81UVDEhEDHlm0v6WN2aGuzUA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1667203560; a=rsa-sha256; cv=none; b=s98E4tUQHrYVVuzPJlGWlN22mBdUDVz8eeZnImhDn4ZekwedcPDL9BrxmoHGnSMDa8X5sQ CvxiHf9EJ9WQDDGVAVciFArosyUD+8OPOuCkseKOOJkj+IN+QsOHkFk4qYzsUhV8rsXz7R nnvu5E5z+MVCanxvPHBB5+HmsmCfDYOjMbLjyeCD84oGik5BZL/QLGdDrj4LQOoZZt3jm6 Hp9oiHLiXAILHj/XWA8rqnWeVqZ2w840GvBk8NKoZEx4cOsa6J+xIZw2kAck/Z9fAJ6BMa 99nsS9rAdcKxXzrSP7VrQ5bMYz7I93Aocjgca/37ZThh2IydDVDbgTfxHgcsRw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267457 Bug ID: 267457 Summary: missing array terminator in netgraph's ng_bridge.h Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: rtm@lcs.mit.edu Attachment #237745 text/plain mime type: Created attachment 237745 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D237745&action= =3Dedit provoke crash in netgraph due to missing { NULL } array terminator This in sys/netgraph/ng_bridge.h: #define NG_BRIDGE_MOVE_HOST_TYPE_INFO(entype) { \ { "addr", (entype) }, \ { "hook", &ng_parse_hookbuf_type }, \ } I believe there should be a { NULL } at the end to prevent code from running off the end of this array. I've attached a demo. ng_unparse_composite() calls ng_get_composite_len(), which returns 3 rather than the correct 2 due to lack of the { NULL }, causing ng_unparse_composite()'s loop to index off the end of the type array. Then ng_parse_get_elem_pad() fetches a garbage function pointer in ALIGNMENT() using a too-large index and calls it. # cc ng6a.c -lnetgraph # ./a.out panic: Fatal page fault at 0x7070705f676e007c: 0x7070705f676e007c panic() at panic+0x2a page_fault_handler() at page_fault_handler+0x1d6 do_trap_supervisor() at do_trap_supervisor+0x74 cpu_exception_handler_supervisor() at cpu_exception_handler_supervisor+0x70 --- exception 12, tval =3D 0x7070705f676e007c (null)() at 0x7070705f676e007c ng_unparse_composite() at ng_unparse_composite+0xf6 ng_struct_unparse() at ng_struct_unparse+0xe ng_unparse() at ng_unparse+0x30 ng_generic_msg() at ng_generic_msg+0x938 ng_apply_item() at ng_apply_item+0xf6 ng_snd_item() at ng_snd_item+0x1bc ngc_send() at ngc_send+0x260 sosend_generic() at sosend_generic+0x384 sosend() at sosend+0x68 kern_sendit() at kern_sendit+0x170 sendit() at sendit+0x9c sys_sendto() at sys_sendto+0x40 syscallenter() at syscallenter+0xec ecall_handler() at ecall_handler+0x18 do_trap_user() at do_trap_user+0xf6 cpu_exception_handler_user() at cpu_exception_handler_user+0x72 --- syscall (133, FreeBSD ELF64, sys_sendto) --=20 You are receiving this mail because: You are the assignee for the bug.=