From nobody Mon Oct 24 21:41:56 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mx7nc6NdYz4gqfX for ; Mon, 24 Oct 2022 21:41:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mx7nc32Jrz3F4n for ; Mon, 24 Oct 2022 21:41:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Mx7nc25DpzMhl for ; Mon, 24 Oct 2022 21:41:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 29OLfuuS095144 for ; Mon, 24 Oct 2022 21:41:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 29OLfuh4095143 for bugs@FreeBSD.org; Mon, 24 Oct 2022 21:41:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 267317] encryption_change() in ng_hci_evnt.c can dereference NULL pointer Date: Mon, 24 Oct 2022 21:41:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rtm@lcs.mit.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.mimetype attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666647716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BBLOdtbHZRa+70nWBturZ5P2cIQsnRWJWe2dkn3oFa4=; b=BjP5S0OCb2LzPYGVFdyLTxTv7nyOxxtnx9rNxRHP83FZE6Wf3i9qVSQ7xmBnzEZMnFOuaS WoEvUd06YqsEHbwSRbexzLH63oPNfzihl3/Bl/IWCgBY9EyJANkSy4KUo9jTrXke9n0iSo YLE9J/JAUxKRp2EQHWTcjPlLkpoE5NIHugE6NAypipbToLEwZxxR0F91oXwc4VrdQd3hRC XjfKaXWz7aGSDbmVAiVTI8IwbX7lC7oSU6izHEXg4zIFOv+PMl5nAQplmN+cBRpmgP2Axx 5uSQrKo1txOWXCg9L/8zQYvmInebFBbss92uvznMDlZEWyDD7+ZDrK4I72Gwlg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1666647716; a=rsa-sha256; cv=none; b=ItnP3pWfzblEFdMZts+ulsUtv8MFkPMQdgR7tstN34ovmUeYZzFv74TgYW6yZ/BVWhsExx UOe5AfVQiuja6mby8RUmQ6xMDVRVMtSk9fD0Rw/8Ex+4zuHltK3pQBsxoBU8D24QokWQZ+ yCPyCliP0Egjd5Wkfp7dc9qTWK6Jnrm9Q5Tz/Q7/pVyWlE1uF7c4PGRKyedVwfknWNO+jA q23LR8l4+BQrN+/TLZS4n2F8UqKgOZG7XKqv+HkkwRHoTc0xC1aY6ZaP1bMZM9rF6cZhX2 iZn9E52Hei1rcppYEax0ABYiaS4TTUrSu8LGfPZGpgX/Yq3RszZUB9JTSst9Zw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267317 Bug ID: 267317 Summary: encryption_change() in ng_hci_evnt.c can dereference NULL pointer Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: rtm@lcs.mit.edu Attachment #237589 text/plain mime type: Created attachment 237589 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D237589&action= =3Dedit Cause encryption_change() to dereference a NULL pointer. An encryption change event packet arriving on a bluetooth hci drv hook that refers to a non-existant connection can cause con in this code to be NULL but be dereferenced: static int encryption_change(ng_hci_unit_p unit, struct mbuf *event) { ...; ep =3D mtod(event, ng_hci_encryption_change_ep *); h =3D NG_HCI_CON_HANDLE(le16toh(ep->con_handle)); con =3D ng_hci_con_by_handle(unit, h); ...; ng_hci_lp_enc_change(con, con->encryption_mode); I've attached a demo that sends a message with con_handle=3D65535: # cc ng13b.c -lnetgraph # ./a.out encryption_change: - failed to change encryption mode, status=3D255 panic: Fatal page fault at 0xffffffc00040c630: 0x00000000000015 cpuid =3D 0 time =3D 1666544229 KDB: stack backtrace: db_trace_self() at db_trace_self db_trace_self_wrapper() at db_trace_self_wrapper+0x38 kdb_backtrace() at kdb_backtrace+0x2c vpanic() at vpanic+0x170 panic() at panic+0x2a page_fault_handler() at page_fault_handler+0x1d6 do_trap_supervisor() at do_trap_supervisor+0x74 cpu_exception_handler_supervisor() at cpu_exception_handler_supervisor+0x70 --- exception 13, tval =3D 0x15 encryption_change() at encryption_change+0x84 ng_hci_process_event() at ng_hci_process_event+0x118 ng_hci_drv_rcvdata() at ng_hci_drv_rcvdata+0xb8 ng_apply_item() at ng_apply_item+0x130 ng_snd_item() at ng_snd_item+0x1bc ngd_send() at ngd_send+0xf8 sosend_generic() at sosend_generic+0x384 sosend() at sosend+0x68 kern_sendit() at kern_sendit+0x170 sendit() at sendit+0x9c sys_sendto() at sys_sendto+0x40 syscallenter() at syscallenter+0xec ecall_handler() at ecall_handler+0x18 do_trap_user() at do_trap_user+0xf6 cpu_exception_handler_user() at cpu_exception_handler_user+0x72 --- syscall (133, FreeBSD ELF64, sys_sendto) --=20 You are receiving this mail because: You are the assignee for the bug.=