From nobody Thu Oct 20 16:26:41 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MtXzj3138z4g0BR for ; Thu, 20 Oct 2022 16:26:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MtXzj1mjmz4C9Y for ; Thu, 20 Oct 2022 16:26:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MtXzj0gmTzw8p for ; Thu, 20 Oct 2022 16:26:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 29KGQfgi081986 for ; Thu, 20 Oct 2022 16:26:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 29KGQfIj081985 for bugs@FreeBSD.org; Thu, 20 Oct 2022 16:26:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 266886] [FUSEFS] Handling of l_whence with fcntl(F_GETLK) Date: Thu, 20 Oct 2022 16:26:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1666283201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aeNdJ+RsEs3msM4vB+T7d96G7umCBNwXmkcF7SdepII=; b=gYjuYz09eLPfnCz56WJQfRpOqqRVEXxlmsBXQ5KfRxI3fhvyWYg1XeiaT4IAPuZP6Dbwst WovCT9wVQqLkR4W+NFCTHip8IdAO44JEruk2xomUgSqzQfvOtFdJqrqTLF1iyo+CqZEsOq dVHQUmCEA8iV1mB+sdmwRkT/MCJuxC5s5i3MIHLZ3QpjQVHT1fERV2awlwtC0Nofknvt5v 1ZwnDLIw6+1PJkrq5VlGYyPt0KW6kbcDxvaRrbP1Yxsf63qTdV28ld6zGCrO3P0o7KFnMb Amlzouuf7aWkVt+eOZxjW10QEJO4wB+JFQKRPan2RhYwLmurwZeA01eJ1aHSvw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1666283201; a=rsa-sha256; cv=none; b=mD2rQWl9Knt9OUqYj2tHCpUnNMU/2mbj7mucLnCbM/29GA2dpXFGTcg0TDvEPLAJL/AdDV m83ZkORHA7uABARKb6J0WCB+rGNDSawMCfZurCeNf1UMb6QIc66zsV0fq8Ny8wZDsrif0R zhByezQh+4XG1rION9mebJpG027Eq5nSJEbK2tlFltBuRRf5yNduf25PqIKEWIb6slEFWc dO2bpFhIpVr4iPVDscOxPhehjaE/ubBASZULG6VC1DSQu0FmAXTSTbuu8+VRCeZ9Li0IuK vMc+uNPW556RNb4t5qfE5h96Ftto+RfQotyxPbD71yglLtG+hkivEg818o2O5g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D266886 --- Comment #5 from commit-hook@FreeBSD.org --- A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D311f68079ff29aabd594c6fbdc97c2bff= 5d91ba5 commit 311f68079ff29aabd594c6fbdc97c2bff5d91ba5 Author: Alan Somers AuthorDate: 2022-10-11 23:00:07 +0000 Commit: Alan Somers CommitDate: 2022-10-20 16:24:19 +0000 fusefs: After successful F_GETLK, l_whence should be SEEK_SET PR: 266886 Reported by: John Millikin Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D37014 (cherry picked from commit 3c3b906b54236841d813fd9a01b1e090f39558ea) fusefs: fix VOP_ADVLOCK with SEEK_END When the user specifies SEEK_END, unlike SEEK_CUR, VOP_ADVLOCK must adjust lock offsets itself. Sort-of related to bug 266886. Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D37040 (cherry picked from commit f6e5319550f60170840f1a07a9cbdd45b5014a21) Approved by: kib (re) sys/fs/fuse/fuse_vnops.c | 34 +++++++- tests/sys/fs/fusefs/locks.cc | 191 ++++++++++++++++++++++++++++++++++++++= +++- tests/sys/fs/fusefs/mockfs.cc | 14 +++- 3 files changed, 234 insertions(+), 5 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=