From nobody Fri May 27 16:37:49 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 157B81B52FF7 for ; Fri, 27 May 2022 16:37:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L8r7x6XbDz3vqP for ; Fri, 27 May 2022 16:37:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C0C8725E88 for ; Fri, 27 May 2022 16:37:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 24RGbnc2013757 for ; Fri, 27 May 2022 16:37:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 24RGbnZE013756 for bugs@FreeBSD.org; Fri, 27 May 2022 16:37:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 262829] epair: New panic when destroying epair interface of vnet jail Date: Fri, 27 May 2022 16:37:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653669469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0pmMCE3/FpM/pywFZlu6FuGXw93PmuTesWflTHx3VAU=; b=rlorZ47xDGhvM+wc5SfxrJCU0qXLZqmSisy7zldwsEbKV8gDFxG/p2PvIE86qWMjsjpsl2 2ahzT4L8qpKwiQdSVvjtXXt3Iw1JVBwK45JRAXpC5X2qIVvValTDOf+vKPDZShMuQfREX0 zzgjqXmYRHbVVDXmPF3OfHIPiT/2M7Ux5w0mAuX9ygjmMzZH3DagWRCtakjISIyZFNnmDE vEW2BYByRyk07p6b9oM0ltA29ucDuLhFAmnbHXNPEaPu9wev1e9VXOvLlLZR72P6pQb9IJ Rzy2/6yANRinrEL0EsXQuQcju+JZ1LKIgB4zaLC+EblWlQmToRvuzFhqILsx/A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653669469; a=rsa-sha256; cv=none; b=NV8M6w3ZrY0H4R4ft9KtNvDhWDJlyioyptCoADKzUWaw3ZuuaJxgzTdCsWwL9H74zGJ+Oz /Qe6AeTjUJzBI+YC/DwnCCkLn+9oKvB0K5pfWEzUSNNbOWhy+RGq4WaFV1ZpzNDLAdQdXD 0o/LuW8ax/qQMLRZE9PkZIBVEdUnOxGK2sZqnTkKaiGVQhA4rEvGbeK4W2Dd3CB5rEaSU+ fXol5ZrJYJNX677RGYjU46NxbZkdm2ogzCJsX8MOcFK1Fv/S+/EfGXhZ1VDl1g7nWfIKFs ifGgWWfMmBsYI/BJzvoaH6hacOZCjwOAM/Y5ElnWsVeDlfseEIigjktdJDjqMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262829 --- Comment #9 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D4dfd3ffc4488e5e2662cdc40deec17d82= 432da0b commit 4dfd3ffc4488e5e2662cdc40deec17d82432da0b Author: Kristof Provost AuthorDate: 2022-03-27 18:23:25 +0000 Commit: Kristof Provost CommitDate: 2022-05-27 16:25:10 +0000 if: avoid interface destroy race When we destroy an interface while the jail containing it is being destroyed we risk seeing a race between if_vmove() and the destruction code, which results in us trying to move a destroyed interface. Protect against this by using the ifnet_detach_sxlock to also covert if_vmove() (and not just detach). PR: 262829 MFC after: 3 weeks Differential Revision: https://reviews.freebsd.org/D34704 (cherry picked from commit 868bf82153e8ff22f09a8860c872149e0fb6bdef) sys/net/if.c | 22 ++++++++++++++++++++-- tests/sys/net/if_clone_test.sh | 29 +++++++++++++++++++++++++++++ 2 files changed, 49 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=