From nobody Wed May 25 09:22:07 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A65F11B3CC3C for ; Wed, 25 May 2022 09:22:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L7QZ73BLBz4YsY for ; Wed, 25 May 2022 09:22:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4E78216CEB for ; Wed, 25 May 2022 09:22:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 24P9M7CI073595 for ; Wed, 25 May 2022 09:22:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 24P9M7aP073594 for bugs@FreeBSD.org; Wed, 25 May 2022 09:22:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 232702] fuser does not list id of processes that have a file Date: Wed, 25 May 2022 09:22:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: ali.abdallah@suse.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653470527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UIwubobAgVDvOXGd00N4CCRe6NVkhGh9XJfRibPuN8s=; b=aTjAgKIenPDd45vK8WIVvVAnPt9AzjjvHzx3xcdNhBmL/0rtOv9hOxNhXwt8eQ9VjJfG3o IoW37wNRvHSt6CCWgGEMapg7921Ve+6pV3BOeBZQuoUo8E09cuCpK/85EMpUjDh6E5koEt 7w+p8koim4dlk5VVbjRr3HDreczRf7ixhtLWQVvniCMNxvZUfo6bMTPrwnosinQPOCORib EfKN9Wj4vg3p6InpZpAl2T24pSEDTugHU2JI1Cg8jAG9LogLHdMN+WWwn4/HcBzwsRuQtT h2Ys00dmexgK99HoYbvMCFKwuFyCot+1uGFOz1xdQj2iAMttwmFJmD/yU6Zl2A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653470527; a=rsa-sha256; cv=none; b=lkk3R/Rcjr5OZLXIGEreXReruCakmeHzh1FCQLt29eLhXV6otkAQSFZNJ1Q0EcUQYSFgY1 OgCNKrwQ3XyixciJPX354MGUVKbIekNDMW9cgP5KzNOw1KDrtGF+07mQN2kM/M2edemBCS cIEK8JKlwW6F6Pz7UkZA2H4KiXDkWJ2R93ewxZfk2Pa1PyxUn0a171XiOAfzGb5WzZJ0Rs rDZ3xYJauw0bMXjJ7crtugtOAfruhiCK/yMyiYl3daWVd6GecAH7LZMROGg24J+DUkQ2jJ hn1oJu0T9Y7HkhPcLtNWz6Vuz6evJIs6v4/IBKyTPjTr4eX0rrggzs5L2XbPJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232702 --- Comment #2 from Ali Abdallah --- Created attachment 234203 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D234203&action= =3Dedit Fix looping over active processes I haven't tested fuser since long time. I'm running 13.1 now on multiple machines, fuser sometimes gets active processes opening a specific file, and sometimes not!=20 It seemed random for me, but after having a closer look at the code, I think the following loop is wrong: while(cnt--) if (p->ki_stat !=3D SZOMB) dofiles(procstat, p++, reqfiles, nfiles); The above might skip active process entries, and IMHO it should be as follo= ws while(cnt--) { if (p->ki_stat !=3D SZOMB) { dofiles(procstat, p, reqfiles, nfiles); } p++; } Attached a tiny patch that fixes the issue for me. --=20 You are receiving this mail because: You are the assignee for the bug.=