From nobody Mon May 23 10:51:38 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 399501B40E0F for ; Mon, 23 May 2022 10:51:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L6DfL6Jr6z3NpC for ; Mon, 23 May 2022 10:51:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BAA8B64EF for ; Mon, 23 May 2022 10:51:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 24NApcNG001069 for ; Mon, 23 May 2022 10:51:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 24NApcPF001065 for bugs@FreeBSD.org; Mon, 23 May 2022 10:51:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 264174] Use of redaction bookmarks or redacted datasets on a boot pool renders the pool unbootable Date: Mon, 23 May 2022 10:51:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: astralblue@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653303098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WuztqbmUWkLSw0MgjpTVbeSqq7AfnjOWEuleT5ZeRNs=; b=oj3AGGC4O1acGtdHPH+SFVlA4PDae7aF9/d8o08u0ZJGS25gjCWoy1gEb9w2OcPx6S9mG6 yd0GmzdqsRMqj+cwJuO7Ai0x4plu5eyRI1wpIlwaMOwNLIx+Dud68XrtysgEQs3RjJ9G8Y 78dJacuONf0DqKGagd4Z6xyvP21hQI8qbJAxJlNF1yfCEoGh3nkL470A1is6gHjGD2+8RH raqcfjqJaV32Ppm4K2HxXj7tXOTYf2w2Zhm048dUv12an4nVgjXsN0qVEg0JZJ1phCmYVf dCXEPyqh/gKFi+MxhQw+8mQdaVT1Lo2Nl+S8+iVb3pFAdtO6mRLfnkPSuTV+3Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653303098; a=rsa-sha256; cv=none; b=UPsKwg4crlcMkqo8BQpv9VxN+uzppTWQGOKFN7TPD2cuyxfvCCCsN3JJ8OqI2DnQdoxL1d bvObNfRXEs11Lc5ogMz/SD4jwLRyzZMGw2lLBdzpXBuzKgepzeaxE6w31rL1MCtMauwOEP OiATCg3Yyq449vpMafJzTNURkIntWP7CVndmo/8zvls/xmY4JybY3m9u2KpdPRAyoMRb+l qVsm/0aBAzoTTeFvFUomGOYoFYJ8jzR9FUsk8e5Ia/gfJSO3Bd0NBNhXqVtOwcHZebvj3B e3uPx115YALorVSqasZFZ2GDaS6RrRC6XzUI8FXqg3v9snhaDrnHX2gOK9bA4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264174 Bug ID: 264174 Summary: Use of redaction bookmarks or redacted datasets on a boot pool renders the pool unbootable Product: Base System Version: 13.1-STABLE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: astralblue@gmail.com src/stand/libsa/zfs/zfsimpl.c defines features_for_read, which contains a s= et of whitelisted zpool features. If any other read-only-incompatible feature= is active on a boot pool (that is, enabled and in use) the boot loader will fa= il to boot from the pool. With ZoR, it is easy to shoot oneself in the foot by accidentally activatin= g a read-only-incompatible feature. Currently these include redaction_bookmarks and redacted_datasets, activated by creating redaction bookmarks and receiv= ing redacted send streams. It would be nice if zfs redact and zfs receive commands checked the feature activation and warned the (unsuspecting) user about this if the pool is a b= oot pool. Suggested message for zfs redact: WARNING: A redaction bookmark was created on a boot pool. Currently FreeBSD cannot boot from a pool with redaction bookmarks or redacted datasets. To undo this change, run: zfs destroy zroot/test/base#redacted To identify all redaction bookmarks and redacted snapshots on the pool, run: zfs get -rHp -t bookmark,snapshot -o name redact_snaps zroot --=20 You are receiving this mail because: You are the assignee for the bug.=