From nobody Thu May 12 17:41:51 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D63351AC10EE for ; Thu, 12 May 2022 17:41:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KzfGm2Hslz3RLJ for ; Thu, 12 May 2022 17:41:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2F25C12BA1 for ; Thu, 12 May 2022 17:41:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 24CHfqVp035237 for ; Thu, 12 May 2022 17:41:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 24CHfq68035236 for bugs@FreeBSD.org; Thu, 12 May 2022 17:41:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 237915] "netstat -i" for ixl/lagg shows idrop as 18446744073709551612 (-4) - incorrectly intialized counters? Date: Thu, 12 May 2022 17:41:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: brian90013@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652377312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pGMR2jNsrfNEDXdJSbZk0facWqAvbZkgdpEZ2JtMDXk=; b=tRekLoYRHaV6k50HDeVD1gQawqY9a2dAlEv9oWbk78bB8VZF29omE9+lcthAcaj7QWgRZO 8f1JdeDoHEGSVq+xJNQh5Bk/o7qDcOUElCqvvB+veS+C0wnC/QXwbnjM5I2uBhuyHzaKzD pSS38wUsanYGd4zZsChF3OtRe1taljxlG0WBhh9nfsVHwj50cFRAMc/D0XxA6qt8858kZ1 g54JMFajaRGMqy0r8aMWHjf0up28HzQAiE/N+A4hOnA9/MTppBv61kYfzMFEugghhccZJO eM/W6U80BS7SrtXZ01VWnwziSLzgEHWFhxlXypohMbqwpDqyFxOPVckfL2o1Aw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1652377312; a=rsa-sha256; cv=none; b=yKCcynhGnFd58HuS21T2lMEJo/TqeY6E0cCA9dT75nNGXJ8Ye7KRr4YkH0gjcn6e54IvtM jvsc9K62+qPnrBdMFK33JV3ry/fNY6fNlOp20bxyu7xDy63HlzrsLjn6iGH53RazIxUc0F xTU27mUij9FuT+UItGbxtMm+PSU5ZC1ymqvRg18MZjgIV4T+GI176D4dFNGV+sqXfB9jM0 usq8JLTXA84OAPuDOuP0/UOSDFmAW3i9mU0O9OjgTQET94TkrcmJMu4MKifYgktb5wD9vv EuQ88yXyBgL+qXRBAr1g4oiaNW5ZfET+3Y1YrNSnriTGnYqIE2bXVlVAp4hvaA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237915 Brian Poole changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #233858|0 |1 is obsolete| | --- Comment #3 from Brian Poole --- Created attachment 233877 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D233877&action= =3Dedit Revised v2 patch to fix counters My apologies but the first patch should not be used. It placed the vsi_reset_stats() call in initialize_vsi() which gets called every time the interface comes up. Someone watching the interface with 'netstat -I xxx -w = 1' will see a jump near 2^64 as the counters are reset. Therefore I moved the vsi_reset_stats() call to if_attach_post() where it is right next to the pf_reset_stats() call. This function is not called when an interface flaps down and then back up. I also removed the call to update_stats_counters() in if_attach_post(). Now= the only call to update_stats_counters() is in if_timer(). This matches the behavior of the ice driver and produces the expected results in my testing. Elapsed metrics are all 0 on boot and periodic metrics don't jump when an interface comes up. --=20 You are receiving this mail because: You are the assignee for the bug.=