[Bug 262710] glabel labels should not be created for snapshots of zvols

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 25 Mar 2022 20:19:10 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262710

--- Comment #1 from Martin Birgmeier <d8zNeCFG@aon.at> ---
One further thought: On the file server, there are zvols like

hal.1/vdisks/903
hal.1/vdisks/904

These are all sliced and partitioned with s4a, s4b, s4d, resulting in device
entries like

/dev/zvol/hal.1/vdisks/903
/dev/zvol/hal.1/vdisks/903s4
/dev/zvol/hal.1/vdisks/903s4a
/dev/zvol/hal.1/vdisks/903s4b
/dev/zvol/hal.1/vdisks/903s4d
<then all the devices corresponding to snapshots>
...

These partitions then have either a UFS or a glabel label, resulting in entries
in /dev/ufs and /dev/label.

It would be better to move these labels to where the slices/partitions appear,
like

/dev/zvol/hal.1/vdisks/ufs/disk903s4a (UFS label)
/dev/zvol/hal.1/vdisks/ufs/disk903s4d
/dev/zvol/hal.1/vdisks/label/disk903s4b (glabel label)

In this way there would not be conflicts when the same label name appears in
multiple zvols. Also, it is similar to the logic applied to "normal" labels,
i.e., those not coming from sliced/partitioned zvols.

As said before, labels for snapshots should not be created at all.

-- Martin

-- 
You are receiving this mail because:
You are the assignee for the bug.