From nobody Wed Mar 02 13:40:57 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5D63E19EA3C0 for ; Wed, 2 Mar 2022 13:40:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K7wHY0m16z4ytR for ; Wed, 2 Mar 2022 13:40:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EEE9524604 for ; Wed, 2 Mar 2022 13:40:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 222DeuIr049622 for ; Wed, 2 Mar 2022 13:40:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 222DeuBW049621 for bugs@FreeBSD.org; Wed, 2 Mar 2022 13:40:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 261751] vt mouse pointer background display bug Date: Wed, 02 Mar 2022 13:40:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: vt X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: emaste@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646228457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ed/WWoYCoseSF+Q9fViuB7qL9iAK8RtHgiD5XkaFLWA=; b=u/guqhLr1yy8O0DJ5NEg/VAGpgqL/yFL/e0HwceLT/tv8iDbtxIzrzzKVOyzA3/E7PO779 A8vj/UyDoc1WzCgRtRhvyVPOtO3NZ3XH0hFUoflkHSJ/dGmI3N50yWgm51vz1fCOFaH+Id Byn8ZZ2t7fOnwLCEPFBw6o9uP+Reu147Qu3BOFSLYUdpC8Hc5s48mSSI/6YZCi1j67oIHG NfhpPGBBrXD/k+b6qTlGZ+gznT+7EMvT/i+MN/pB19mi/8TL5bd3rpRWU6oyMVmjalhX2Y kV0vm/ZRhzXHNb8BxqGRG+SXGtO+2ePH3O927NZysQo3iRJTposUOObKxAV35Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646228457; a=rsa-sha256; cv=none; b=opAAkC9Za00cGIEuKxnWkQNnlKTOMZKGRoBsiEC+rJzouVEvheKo/Wa8hZ8/OY6PWP8yR5 vZbCwgCYEsBejLvQ/0gA9Z5oU5moZ5XrkPwVbatcrKV8XyO5BdXCjQn6f2VQ87uEbjSmge TqO46ebL+EOtulmAHJAr7PO6V2InsHWrI2SfiOaQkzY86GSDX50u7OL65MSlrkl4NnaBvK PAlaVS52ff0WxU7jhKzoZl4MgqRf7lCMFmMZUxJR1wpq75+3PnSZr5meKN/Q2oUT58WDei 1EMbFaE81n98U60b3tk703AmECNpzAziTUfTqycGoCSKliST/pb/3Eyb/X0Bfg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261751 --- Comment #4 from Ed Maste --- Thank you for the photo, I have an idea what's happening here and why I don= 't see it. I believe this issue is reproducible with vt_vga only, not with an = EFI framebuffer. In sys/dev/vt/hw/vga/vt_vga.c:vga_bitblt_one_text_pixels_block() there is an optimized special case for a "pixel block" having only two colours, and a m= ore general case for n colours. In the case in your photo we are using the gene= ral case. I suspect the general case has the R and B channels swapped. If you can ea= sily try a patch we could confirm this by disabling the optimization. For exampl= e, diff --git a/sys/dev/vt/hw/vga/vt_vga.c b/sys/dev/vt/hw/vga/vt_vga.c index 563867399e53..c8041f1dac8b 100644 --- a/sys/dev/vt/hw/vga/vt_vga.c +++ b/sys/dev/vt/hw/vga/vt_vga.c @@ -770,7 +770,7 @@ vga_bitblt_one_text_pixels_block(struct vt_device *vd, * The pixels block is completed, we can now draw it on the * screen. */ - if (used_colors =3D=3D 2) + if (0 && used_colors =3D=3D 2) vga_bitblt_pixels_block_2colors(vd, pattern_2colors, fg, bg, x, y, vf->vf_height); else If I am correct this would result in a display that is consistently incorre= ct -- the entire dialog background would be red, not just the location of the mouse cursor. --=20 You are receiving this mail because: You are the assignee for the bug.=