From nobody Thu Jul 21 17:06:08 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lpf9D6Ndbz4X51G for ; Thu, 21 Jul 2022 17:06:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lpf9D5KhRz3Dym for ; Thu, 21 Jul 2022 17:06:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Lpf9D4NqLzTfT for ; Thu, 21 Jul 2022 17:06:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 26LH68oC085746 for ; Thu, 21 Jul 2022 17:06:08 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 26LH68Rq085745 for bugs@FreeBSD.org; Thu, 21 Jul 2022 17:06:08 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 265005] asmc(4): Add MacBookPro6,2 support Date: Thu, 21 Jul 2022 17:06:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: feature, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? maintainer-feedback+ mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658423168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sw1XszC+aO5sUyQSsbC1lGZmgMy0xcAM6tZQKRHJJ8Q=; b=P71DzH6s0ATmzAELO87N/8rFDBa4XYEO43wup0GPDPN+sJ0cQ6U58dCxgCJzvcSIomMJwL 9dhl6nPc0ZN2PgDGthSQh8dAtp7xIe65A51KtHxcJ5CQyJ2yHyyJbkqDRDIfEns9nsFS3l ggOHTTrXpxHtODEKr7tnfvYmVOGj896zCjOvqBRf9DPSBmkxvYqwSwJq1tUnzMpIDlRkOx iLl0WiMS90egMKPbbAASzT2rVrSBOqTJmPMZGXznJWRn8+V54fxLJ80Jv7bMNcv+znmsL6 OoQhgIVPsxsNjSR4B5B4JewsUON6j3ptRc+lPPZmn6JTpgFJV3PgpJhEICiGPQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658423168; a=rsa-sha256; cv=none; b=FgStp6k1xthoaFchtRYNn4qRog1JBgLyiv50img9ZqVcgGJBb9+s8lcpEeI251d3ifeoE7 vIMdL9Aq1YOxDgzR4jbYuwBgbaoNwSxQludfS38aw/9QGIwu8prKb6naA4j8h8bG3d/G4U kia82sVrRzM4OEUZF+gs/XeaeLUdr3Hh/xkdjv3KfZddezVHCckhnpVwCZ4DjmPePFkpE/ bAKzyAY0OO8aoKU/vNRoZyu5s44ev2K/iz/tGZJFxGgdwkclBP3Y3TPekOWordgQ5eZuTb GWsWwuon3dPjelHaKgZylhvopHRD2A+g3cQX1hQOo0ydq6Lkg0v75LZerPNmag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265005 --- Comment #7 from Mark Johnston --- (In reply to ed crowe from comment #5) Thanks! With respect to interrupts, what happens in asmc(4) is that an interrupt triggers a call to asmc_sms_intrfast(), which determines the interrupt type, latches it in sc->sc_sms_intrtype, and potentially prints a message. Then,= it schedules a thread to deliver the devd notification, by calling taskqueue_enqueue(). That causes asmc_sms_task() to be called. So, the question is whether we do in fact want to hide these interrupts from devd. Per comment 4 it seems like the interrupts aren't spurious, i.e., the driver is behaving more or less as intended. So I think the real question = is whether the light sensor interrupt is generating "too many" notifications: = when running top(1), do you see devd consuming a significant amount of CPU time?= If not, then I wouldn't worry much about it and can simply commit the latest patch. --=20 You are receiving this mail because: You are the assignee for the bug.=