From nobody Mon Jan 03 05:44:43 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A49F5193F4D6 for ; Mon, 3 Jan 2022 05:44:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JS4Sq0fQKz3nTv for ; Mon, 3 Jan 2022 05:44:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E64001F8FC for ; Mon, 3 Jan 2022 05:44:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2035igBg019603 for ; Mon, 3 Jan 2022 05:44:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2035igoS019602 for bugs@FreeBSD.org; Mon, 3 Jan 2022 05:44:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 260375] NFS server truncates directory cookies to 32-bits Date: Mon, 03 Jan 2022 05:44:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641188683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9CHAAYsTQ1Q5hIDH5k+jAVa8mOyIuFacmDBbQXRfNFc=; b=pmKeKkSQGKSQXBPN9wjukfirEyRniFRV5NUxuVEae1GieHkMZ10sdNP5De62L2SmA+kpCw kqjeuU7gkekXZBO4VnHku2ZnNR4YUFCnSWILe8VK6bXih+LuJZtVKGz45e4fwgHTeBG7Gj TS8biUWkyhRJ1NlquBBUpcE6TyqbnKRD/E5xFmpf41bVSnhZnds94O1XkqT1GcMHYK9JJ0 6er+AqwuQBlctXO5o35dBfubwu0pKdWB77FBR9L7XUGKWfYOxsWomgZeR8CR+/8XMv1FdM 10P64eO4Ad/eB5OMSB6+cb99fw0H+9htiUkSpTb1Wr5/w1iKBxAMEhcPbusP7Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641188683; a=rsa-sha256; cv=none; b=FVtR3AA893YLwoV5bQhIYZDBYpm4LYkmjDQXHvWjILUrwcMmYLSRkmVSrumoNhkCTR7GZj XlHoNqv3TdlfPwY+FCfLxZhRL0y4tu5l96WolyTpzTc427QNNg4IMLDTgUnWRGZC5a9NSK cMLZm7hrW9VVXatFXTBBVRoTNWCfkGzFNOK+OssdlhuR4bdiZ7gZazHK1ZsqAbiRpvGzp6 04ju2XW/xPTBgxOlSQFXCrqcacDgZ4s/BppKtsJool4m0q62ACKie6n54qbqReu/U31SRw 9a9n+uSuCkAluhi/A3f0CqxVdRM2j0LsMU30NvBd8QasMaD2mYVda4/uPDE9mA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260375 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D374e8226d2252da6421a05313a7ac223f= c00c432 commit 374e8226d2252da6421a05313a7ac223fc00c432 Author: Alan Somers AuthorDate: 2021-12-13 03:57:14 +0000 Commit: Alan Somers CommitDate: 2022-01-03 05:37:51 +0000 nfs: don't truncate directory cookies to 32-bits in the NFS server In NFSv2, the directory cookie was 32-bits. NFSv3 widened it to 64-bits and SVN r22521 widened the corresponding argument in VOP_READDIR, but FreeBSD's NFS server continued to treat the cookies as 32-bits, and 0-extended to fill the field on the wire. Nobody ever noticed, because every in-tree file system generates cookies that fit comfortably within 32-bits. Also, have better type safety for txdr_hyper. Turn it into an inline function that type-checks its arguments. Prevents warnings about shift-count-overflow. PR: 260375 Reviewed by: rmacklem Differential Revision: https://reviews.freebsd.org/D33404 (cherry picked from commit 32fbc5d824f51f97220bc5c61a23e0bf3ff2b470) sys/fs/nfs/xdr_subs.h | 10 ++++++---- sys/fs/nfsserver/nfs_nfsdport.c | 13 ++++++------- sys/fs/nfsserver/nfs_nfsdsubs.c | 6 +++--- sys/nfs/xdr_subs.h | 12 +++++++----- 4 files changed, 22 insertions(+), 19 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=