[Bug 262091] vt newcons: mark extend event handler only updates mark_end, but not mark_start

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 21 Feb 2022 10:14:08 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262091

            Bug ID: 262091
           Summary: vt newcons: mark extend event handler only updates
                    mark_end, but not mark_start
           Product: Base System
           Version: Unspecified
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: bugs@FreeBSD.org
          Reporter: sblachmann@gmail.com

This bug affects the word/line mark modes (explained in PR262090)

When you move the mouse behind/above the word or line, the originally-marked
word/line is _no_ _longer_ marked.

From a short peek into the vtbuf_set_mark() function in vt_buf.c, I think the
latter bug could be rooted in the VTB_MARK_MOVE and VTB_MARK_EXTEND case
handling.

There only the mark_end is being changed, not taking into regard in which
direction the move/extend was done.

Correct behavior would be:
- mark_start should be adjusted when the mouse is dragged to a position
before/above mark_start
- mark_end should be adjusted when the mouse is dragged to a position
after/below mark_end.

-- 
You are receiving this mail because:
You are the assignee for the bug.