From nobody Fri Feb 18 18:00:04 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E803719DDECD for ; Fri, 18 Feb 2022 18:00:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K0fc44Tl0z4YM1 for ; Fri, 18 Feb 2022 18:00:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7A6BB21CEC for ; Fri, 18 Feb 2022 18:00:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 21II04k8071105 for ; Fri, 18 Feb 2022 18:00:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 21II04bj071104 for bugs@FreeBSD.org; Fri, 18 Feb 2022 18:00:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 262038] fts: Check for readdir errors Date: Fri, 18 Feb 2022 18:00:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: martymac@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645207204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nQ1E8WntC6VLXyrB+mZlg/DH0IUAssuBBPW16BIWRJk=; b=Gc8WJMiRB02Dnu75JmBGaKsdu7Jtm173AiMKVYW5saiEoDoQeLfNlJ7ceqTXAbpz0LVqbp 7Um/oBENNANWJblzzdvkhsjrZH1GuOuNlTg9YMgxsaeE/vtrZN2NToQma7S8ZIL+iAgf8e A3xvhKRuF54C5gSOiKq1qvkP0MKiz5rFzlCLp+OcveB/aAV/cjnzmGkQc4kmIDCtfGKT5y nShVjVzjNeDTii1DFDDvYKuAg64Xcflg+qut6qvZM9xIvmhv/Ow7T5AVAp1qT+6RbTCL0A KXj5wqV0HzlDqMGXN4F6SMgn1hggl/ytXAI9OEq35ivf4GEpV7GJykMb/5DSbw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645207204; a=rsa-sha256; cv=none; b=KXnkDAZQtnGca/VeN1p6MlW1Sz9s+AHD5/KNnwvZQkwQwOKczUmKW2bN3hx6LMN4PSrPjT RrRRzg+pHQqBQqLqiOJm3hGnd5dtFeW8WX382LXvDMjS7sfZSacJfBd5qccXWGI/cOp+hK Bdd8aRvrZI354aGP/IPfPy7CzoM9HD304tQr0RYt/4A1zldoGvmerQVcsGLuUTpS+pkzw5 /K6AIjix2AVXGFyCJEo5yfPZQ40QWR0DRah1VeAxvXTOVxoo320LpVulVRUXD1TBSYQ26Y yQsDPsNDMPGVlOup33suEZ/djD1dQXISrmmtii4F5yl/U9T5BqLC/W5XuoYbyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262038 Bug ID: 262038 Summary: fts: Check for readdir errors Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: misc Assignee: bugs@FreeBSD.org Reporter: martymac@FreeBSD.org Created attachment 231923 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D231923&action= =3Dedit Check for readdir errors Hello, Here is a patch originally reported by Amir Goldstein to one of my projects (fpart), which embeds our version of fts(3). See : https://github.com/martymac/fpart/pull/37/commits/dec9d40d9b4b9551791d61a15= 442aab8537a26f4 The patch fixes the fact that the fts_build() function does not check for readdir(3) errors and erroneously assumes it always succeeds. The same bug has already been fixed in gnulib, see : https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=3D6835fc458f30 The attached patch applies to latest -CURRENT. Best regards, Ganael. --=20 You are receiving this mail because: You are the assignee for the bug.=