From nobody Tue Feb 15 06:10:29 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DEECA19C5C58 for ; Tue, 15 Feb 2022 06:10:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JyW0j2LxZz4qRP for ; Tue, 15 Feb 2022 06:10:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 073291D36E for ; Tue, 15 Feb 2022 06:10:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 21F6ASN9010123 for ; Tue, 15 Feb 2022 06:10:28 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 21F6ASe6010122 for bugs@FreeBSD.org; Tue, 15 Feb 2022 06:10:28 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 261446] freebsd-update should not create boot environment when it's not making changes to the boot environment Date: Tue, 15 Feb 2022 06:10:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644905429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FsDSDh3KqAhZ17IXOdeCIXpJ7myKHuUovP3ecH4wWS0=; b=U+IfFmapD4rhnJ1CGKv95T/LApSe58KYZs47udMxP3BefBGmNrc7NXJA6XFgLVJs6YGYTB W3TwxCcAV/+Di6K0ZsbEXxfh3Lnv8xeZsOzXTk/ed3KYw+pi+U3y0PP6jb6FGP9wY1fg41 bKVv6Vgpidiec5uAoyH7iEO0QGGnsPCMmBN68CEy+b7AMsWEit3oUkHNSJtMq+QNeban09 IOpy8nAPlAnpxjWVJRANrAWBQpFBqijItb5xG9jxgvZPDnWIQyHCn++RtrWk0t5hCEhaOe Qkky9A2BtINSBMGJLML5QWrTojpRPb3/zldLLRW68r7y38sEUlFQADwk9RE7QA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644905429; a=rsa-sha256; cv=none; b=MnZOg0my/4lcBO2H+MkEmswGYvPTnepsLKNcKOOUJfdeMikgJeSc49ZLeoAIgcxsjJ7zI5 t2AD1LeNQIbbtAsm8tVh7y3/atlA1FVekAyoyZzGsZjjaVP6WHqwiHP1JBe+OPyavommaf QE+Hefj7Ybt35m+Sa/PsfUHc2PMYiOGQFzXpupfiwmLT/IZFSJQtqwZsts5FmWOq38RID3 xsvPutU8+gcpSvQ3ftIxDPLNsuT5L8C1cOtN9R8CI/WZEtaFvXyPISGcutfiTV6omsQWTi mOHb7sU2ToL/ybRkn855QJc3+oSvlWTFaiYyrDgCC0gJyYNI7xgHxNtZv5q58A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261446 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D47c07814051a86fec9088a1f78d64fdad= a8abed6 commit 47c07814051a86fec9088a1f78d64fdada8abed6 Author: Kyle Evans AuthorDate: 2022-02-12 21:36:24 +0000 Commit: Kyle Evans CommitDate: 2022-02-15 06:09:50 +0000 freebsd-update: improve BE creation feature This addresses one nit and one bug in the BE creation feature of freebsd-update: The nit addressed is that it currently only names the BEs after the userland version, but the kernel version may be higher. After this change, we request both and pass them through sort(1) to choose the highest. This is especially helpful if a freebsd-update patch touched one but not the other. The bug fixed is that roots updated that are not located at '/', e.g., by using -b or -j, will no longer create boot environments automatically. There's a very low chance these will actually change the BE in any meaningful way, anyways. It could make sense in the future to allow an argument-override to create the BE anyways if someone comes up with a non-standard setup, e.g., where a jail is an important part of their boot environment on an appliance or some such setup. Half of this patch is submitted by delphij@, the other half kevans@. PR: 261446 (cherry picked from commit e01e8f911b935eabcc35b4d121951e4e21042ee5) usr.sbin/freebsd-update/freebsd-update.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=