From nobody Fri Apr 15 16:54:02 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7018E8D2932 for ; Fri, 15 Apr 2022 16:54:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kg2V20vdgz3QBC for ; Fri, 15 Apr 2022 16:54:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F374518AFB for ; Fri, 15 Apr 2022 16:54:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23FGs1av025247 for ; Fri, 15 Apr 2022 16:54:01 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23FGs12h025246 for bugs@FreeBSD.org; Fri, 15 Apr 2022 16:54:01 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 263297] [netinet] [742e721] Changes in udp_tun_func_t() breaks if_wg from net/wireguard-kmod Date: Fri, 15 Apr 2022 16:54:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rhurlin@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650041642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HIIbsnmdPEw8+3b2hOvAY3FbFv0hhEBuJC2iym8UIiI=; b=FSt6CS0zkh0EDxk3tAAVgnmMFNBM0LsD/7hvKRbNMsoq9ertXf7cxlcVisxpnWacHJjsKG 7B9Iv4Bk1rd4+QejNn5Zomgq8JakWr6wjqebF69s5a7chZ4gdMi8tUy4c6jH8R2DIB9BGZ kCwtOTcyeU0/5y8kaVqBJ71g2Z0iUdmkE8PkiXgZVXVrOpSRgQ/XkhN3axSqHVl5l1BfFJ cSX81T5GhWmYreN1nkfze+RtEq93+3vMOGLPLWpRMHMthRiw3TC49PG3vbMA+WURwL1l89 vDUG9wTFXuO8ynbrVtBgBCOeXiJ+b6NNTEm38hJeIYTD5ig7y2J6Cx5CyAfrIw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650041642; a=rsa-sha256; cv=none; b=QZ37SzYGyW5vcjY5NAii39A3bvo1qx2nJ6ftlkuwM0g5mHOLPMWERfZbDvGmb9Z/OM0PK6 Li/2uaqr+ZLo+7AkFOQ5lQfp9tGbihBrAVo5hpeMgrDixMm6gk1WtZw/JBSSVfT15cuQwZ RfPC/MpvvO+XY7jB0h30IzQhhfnptg8WiVBMlpOHXx4fAu8/7Ca1h+uOUOD1b3Raf7/whv kLtwD47w6OASygYLNbf1KJr9XPuxM52y/USp2HIZwXh+hp8uKRMjJ0ZdI8jXv9v68QD4r8 IqvJ2mELNn/jEacLdcYsigpPfMKlYiNM3rVpAHoQMDP8XXOUdWVrR2WUrKK0nw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263297 Bug ID: 263297 Summary: [netinet] [742e721] Changes in udp_tun_func_t() breaks if_wg from net/wireguard-kmod Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: rhurlin@FreeBSD.org On my 14.0-CURRENT amd64 box, it seems that since the commit of base #742e7= 21 [1] ("allow udp_tun_func_t() to indicate it did not eat the packet"), the net/wireguard-kmod port build has stopped working: [..snip..] =3D=3D=3D> Building for wireguard-kmod-0.0.20211105 machine -> /usr/src/sys/amd64/include x86 -> /usr/src/sys/x86/include awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/device_if.m -h awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/bus_if.m -h awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/net/ifdi_if.m -h touch opt_global.h Warning: Object directory not changed from original /usr/obj/usr/src/amd64.amd64/sys/RHURLIN/usr/ports/net/wireguard-kmod/work/= wireguard-freebsd-0.0.20211105/src cc -O2 -pipe -fno-strict-aliasing -include compat.h -Werror -D_KERNEL -DKLD_MODULE -nostdinc -include /usr/obj/usr/src/amd64.amd64/sys/RHURLIN/usr/ports/net/wireguard-kmod/work/= wireguard-freebsd-0.0.20211105/src/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common=20 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=3D./machine=3D/usr/src/sys/amd64/include -fdebug-prefix-map=3D./x86=3D/usr/src/sys/x86/include -MD -MF.depend.i= f_wg.o -MTif_wg.o -mcmodel=3Dkernel -mno-red-zone -mno-mmx -mno-sse -msoft-float=20 -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -W= all -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error=3Dtautological-compare -Wno-error=3Dempty-body -Wno-error=3Dparentheses-equality -Wno-error=3Dunused-function -Wno-error=3Dpointer-sign -Wno-error=3Dshift-negative-value -Wno-address-of-packed-member -Wno-unused-but-set-variable -Wno-format-zero-length -mno-aes -mno-avx -std=3Diso9899:1999 -c if_wg.c= -o if_wg.o if_wg.c:711:37: error: incompatible function pointer types passing 'void (struct mbuf *, int, struct inpcb *, const struct sockaddr *, void *)' to parameter of type 'udp_tun_func_t' (aka '_Bool (*)(struct mbuf *, int, stru= ct inpcb *, const struct sockaddr *, void *)') [-Werror,-Wincompatible-function-pointer-types] rc =3D udp_set_kernel_tunneling(so4, wg_input, NULL, sc); ^~~~~~~~ /usr/src/sys/netinet/udp_var.h:181:65: note: passing argument to parameter = 'f' here int udp_set_kernel_tunneling(struct socket *so, udp_tun_func_t = f, ^ if_wg.c:722:37: error: incompatible function pointer types passing 'void (struct mbuf *, int, struct inpcb *, const struct sockaddr *, void *)' to parameter of type 'udp_tun_func_t' (aka '_Bool (*)(struct mbuf *, int, stru= ct inpcb *, const struct sockaddr *, void *)') [-Werror,-Wincompatible-function-pointer-types] rc =3D udp_set_kernel_tunneling(so6, wg_input, NULL, sc); ^~~~~~~~ /usr/src/sys/netinet/udp_var.h:181:65: note: passing argument to parameter = 'f' here int udp_set_kernel_tunneling(struct socket *so, udp_tun_func_t = f, ^ 2 errors generated. *** Error code 1 [1] https://freshbsd.org/freebsd/src/commit/88162f7abd61206c98432f2c0de869a59be= 13854 --=20 You are receiving this mail because: You are the assignee for the bug.=