From nobody Mon Apr 11 14:53:40 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7F15E1AABEDC for ; Mon, 11 Apr 2022 14:53:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KcX103BSmz3Qlp for ; Mon, 11 Apr 2022 14:53:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BAFB72510A for ; Mon, 11 Apr 2022 14:53:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 23BErd2u094446 for ; Mon, 11 Apr 2022 14:53:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 23BErd9P094445 for bugs@FreeBSD.org; Mon, 11 Apr 2022 14:53:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 262983] net.pfsync.carp_demotion_factor value is "ignored" Date: Mon, 11 Apr 2022 14:53:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649688820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ol7Obrd58sdAo0Q58SNHfURqsuuQzXWGWWSgWRYmT6w=; b=JRO+7XRMEc1ydLRV4vZY+06xVevRof6LT15A9eD+Xp/9glAcM80kTlJQFfsZ2TAfwTE3Hv B2+7XGcVkIFUp/NATxD0bHygO/u4SRXK6JxLuJ0AtjBqgj+MV5xEszeBXbbMGv8O/ayru+ QIUDgJueZZ35w5j9ndDVVOzZErzuvB2ooTjoeiWwQ4L25s8p9FfWlghhrx6ZEN9jr1Q+7T /ir0n5/i+rQSmX5fF/FrGFtvlFwGTa3m/8QYvaQD1WVknOcHr3Ko27BP6NRByJeF0oz2EV A2YCGkVEzVEmbj1ibtTbaunAFNuvHdMFyTAa9/S3n80I21mSC2eTczUidEc3bQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649688820; a=rsa-sha256; cv=none; b=PEty+eTL6AS4INNpsXZixi22JOjSql1n0Qu5dxv4DiihjFG21VkRXOfoh+jnUexyDUh/bk 0cqtiSOHTwRdVMOx+vDooCFAHikdL3HVjvnqFL583lGJS8Fj76NdmTmqU3NQu2pjlIZpwa YwUpwQKZ2COyE3cbmukT5kwLnyt21KrRUXcFbwbKZfMMhzv/ibwaNOyUhu84pofKf0Vwe7 GKVcn4jTrRLDx3vxjUeaWezKDRXf8vB/iiFCELkHBdNnF0+ZdtADXQXdpLb6VOHTepmY4h oOLXTcuNUR7i11f8mesvnYUr+k6RRijKVHSUf4HzaCPgYB2/ALWHetAruuHG5A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262983 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D44250a19c8fd442e106aeb586bba33215= caaedc5 commit 44250a19c8fd442e106aeb586bba33215caaedc5 Author: Luiz Amaral AuthorDate: 2022-04-02 10:09:06 +0000 Commit: Kristof Provost CommitDate: 2022-04-11 14:52:51 +0000 pfsync: Add CTLFLAG_VNET to carp_demotion_factor sysctl When trying to avoid a CARP demotion during a pfsync service restart, I noticed that a non-default value for the net.pfsync.carp_demotion_factor sysctl was not being applied during the demotion. The CARP was always demoted by 240. After investigating, I realized that the sysctl was using VNET_NAME() without the CTLFLAG_VNET. PR: 262983 Reviewed by: kp MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D34737 (cherry picked from commit 654c1b8ef3c0fcbad3a77ea2a6f35c0dffc86e88) sys/netpfil/pf/if_pfsync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=