From nobody Thu Apr 07 18:10:42 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AD8961A90BB8 for ; Thu, 7 Apr 2022 18:10:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KZ8ZB3dC2z4Zmt for ; Thu, 7 Apr 2022 18:10:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5BBC615286 for ; Thu, 7 Apr 2022 18:10:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 237IAg5a089147 for ; Thu, 7 Apr 2022 18:10:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 237IAg13089146 for bugs@FreeBSD.org; Thu, 7 Apr 2022 18:10:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 263124] sys/x86/isa/clock.c: lapic_calibrate_timer() in cpu_initclocks() breaks compiling for non-SMP Date: Thu, 07 Apr 2022 18:10:42 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jhb@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649355042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2QA/7miBvr7l1sxgNvusoFBf1H/mNK4yNIgprnVlQhk=; b=Et7UjRkiXbBq1VnP6/p9R6uFlGql7ZgMgGElZtytuhIMEUV6TYJft8dc2X/AsNas/tIL1y FN8/trRUFb73yYkv3jKHoHg39QXtW8VnClO/aK/IV1wRSNpS7EBxWlf59RdSluEp+2yYa0 TH3RHimH1KYX98m+2vOyOAvGtrQgDnTF7sqQtb2Hwgwh496gknuHc3rPiIpbgkQYU/tTUh BcAkYIxpZEOHh0grFJKLfmiBpWHFgEMaOPVAZY0KOHtkg5j8VRKIQFhR+t2TpK9bXX+4aL UdbEcWxWmWEEa85GlfSWnuixu7RkkA7E8lUHZJwi9R3Ixe2PdTnSdYo0x2L0aw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649355042; a=rsa-sha256; cv=none; b=BHazNIpLP86EVv0GRv+gBbNtir8V+0RRjz9oU8q3D/YUfDBFAw4yVtY408QmSCp+bOQ34l WsuI8IzDkgrVAeASYAZ0rj7KxYLEpUw2OOFmwY2oNw6fRlkuzjGofDLn+sreZz6WP/Pd58 HbMBH1FEEmHy3/C6xA23pT+Jw7WO/P0kuNb2C96hRklz+iVwOPgxo0U1Ndje7aItSpeh4J 4jqSsHNXKBjn5u6mdfjXH+/wGb4vwdbWT4/be8a9WJKc67AXYqGYGyw1KT0fvk4E5BN3cR gYsGghS6idQYegximy4/3lU+bd8L/JG1YUPdMpgFEVZmEsocHckw7a2hKqRq/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263124 John Baldwin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jhb@FreeBSD.org, | |markj@FreeBSD.org --- Comment #1 from John Baldwin --- Probably the code in clock.c needs to be conditional on DEV_APIC (device ap= ic on i386 sets this, and it is always on for amd64). For your system you really want 'device apic' I suspect even if you don't w= ant 'options SMP' as you get less IRQ sharing when using an I/O APIC in place of the old 8259A PICs even on a UP system. Also, at this point removing 'options SMP' doesn't really buy you anything = as we always compile the LOCK prefix in for atomic operations now. --=20 You are receiving this mail because: You are the assignee for the bug.=