From nobody Mon Oct 11 12:04:02 2021 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id ACA0B180F298 for ; Mon, 11 Oct 2021 12:04:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HScsG4FqBz4YbM for ; Mon, 11 Oct 2021 12:04:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 721A820C18 for ; Mon, 11 Oct 2021 12:04:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 19BC42bo046008 for ; Mon, 11 Oct 2021 12:04:02 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 19BC42e2046007 for bugs@FreeBSD.org; Mon, 11 Oct 2021 12:04:02 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 259068] ext2fs can violate some INVARIANTS if file system is damaged Date: Mon, 11 Oct 2021 12:04:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rtm@lcs.mit.edu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D259068 Bug ID: 259068 Summary: ext2fs can violate some INVARIANTS if file system is damaged Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: rtm@lcs.mit.edu Created attachment 228583 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D228583&action= =3Dedit A damaged ext3 disk image that causes INVARIANT failures. I've attached a damaged ext3 file system that trips over two INVARIANTS in CURRENT: VNASSERT failed: vp->v_type !=3D VNON not true at /usr/src/sys/kern/vfs_cache.c:2404 (cache_enter_time) panic: Assertion dvp !=3D *vpp failed at /usr/src/sys/kern/vfs_cache.c:20= 84 The first is caused by a directory entry that refers to an un-allocated inode; ext2_lookup_ino() calls cache_enter() regardless. The second is caused by a directory entry with i-number 2 but which is named neither . nor ..; perhaps ext2_dirbadentry() or ext2_search_dirblock() should filter these out. To see a panic on a CURRENT system with INVARIANTS: # uname -a FreeBSD stock14 14.0-CURRENT FreeBSD 14.0-CURRENT #0 main-n248636-d20e9e02d= b3: Thu Aug 12 05:47:18 UTC 2021=20=20=20=20 root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64 # gunzip ext36.img.gz=20 # mdconfig -f ext36.img=20 md0 # mount -t ext2fs -o ro /dev/md0 /mnt # ls -l /mnt VNASSERT failed: vp->v_type !=3D VNON not true at /usr/src/sys/kern/vfs_cache.c:2402 (cache_enter_time) --=20 You are receiving this mail because: You are the assignee for the bug.=